From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 471C1C5AD7B for ; Mon, 10 Aug 2026 18:29:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wtUk5-0002tq-DB; Mon, 10 Aug 2026 14:28:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wtUk3-0002ob-Ac for qemu-devel@nongnu.org; Mon, 10 Aug 2026 14:28:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wtUk1-00051A-CO for qemu-devel@nongnu.org; Mon, 10 Aug 2026 14:28:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786386532; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SJR3Cs2bN/dCbv2Nfw0pTmRmj9q6zB5rvEwYdg3F0uY=; b=dS7AKt44F75/9jiF/PLyb7ukdR3DrC8SII35e9vNgCB+cOGpENOODqj82PDCrF2361yV4h 0ZtaQI4WqdEp1zDylLl4k9c0H/l9xOvHyzQpIEeZ0NtrgBwydrwhp2BZ6RtcAMJM3GDtgA +WG8/FNDM4L4lIMM3Nw/s0lkdPaA/gY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-OLJJ8zPtNV6JqgnhvqgK9A-1; Mon, 10 Aug 2026 14:28:48 -0400 X-MC-Unique: OLJJ8zPtNV6JqgnhvqgK9A-1 X-Mimecast-MFC-AGG-ID: OLJJ8zPtNV6JqgnhvqgK9A_1786386528 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C2F7D195605B; Mon, 10 Aug 2026 18:28:47 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B31CB180049F; Mon, 10 Aug 2026 18:28:46 +0000 (UTC) Date: Mon, 10 Aug 2026 19:28:43 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Markus Armbruster Subject: Re: [PATCH v2 29/39] monitor: reject readline monitor when HMP is disabled Message-ID: References: <20260626-qemu-no-hmp-v2-0-8af31bc54c61@redhat.com> <20260626-qemu-no-hmp-v2-29-8af31bc54c61@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260626-qemu-no-hmp-v2-29-8af31bc54c61@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.746, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jun 26, 2026 at 01:19:30AM +0400, Marc-André Lureau wrote: > When QEMU is built without HMP support, reject '-monitor' (which > requests readline/HMP mode) early in monitor_init_opts() with a > clear error message directing users to '-qmp' instead. > > Signed-off-by: Marc-Andre Lureau > --- > monitor/monitor.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) This will need rewriting from scratch as the code all changed with the introduction of QOM classes for monitors > > diff --git a/monitor/monitor.c b/monitor/monitor.c > index 2dec0e299af..f443f406b4c 100644 > --- a/monitor/monitor.c > +++ b/monitor/monitor.c > @@ -764,6 +764,16 @@ int monitor_init_opts(QemuOpts *opts, Error **errp) > MonitorOptions *options; > int ret; > > +#ifndef CONFIG_HMP > + const char *mode = qemu_opt_get(opts, "mode"); > + /* readline is HMP.. */ > + if (mode && g_str_equal(mode, "readline")) { > + error_setg(errp, "HMP monitor is not available," > + " use '-qmp' instead of '-monitor'"); > + return -1; > + } > +#endif > + > v = opts_visitor_new(opts); > visit_type_MonitorOptions(v, NULL, &options, errp); > visit_free(v); > > -- > 2.54.0 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|