From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Philip Mueller <philm@manjaro.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] iio: imu: bmi270: Match PNP ID found on OneXPlayer X1 Pro (AMD)
Date: Mon, 10 Aug 2026 22:04:04 +0300 [thread overview]
Message-ID: <anogpNeCbeF2UnUA@ashevche-desk.local> (raw)
In-Reply-To: <20260731195325.44453-3-philm@manjaro.org>
On Fri, Jul 31, 2026 at 09:53:23PM +0200, Philip Mueller wrote:
> The OneXPlayer X1 Pro (AMD) uses 10EC5280 rather than BMI0260 or BOSC0260 as PNP ID.
> Adding the ID will enable the BMI260 accelerometer on the device using the bmi270 driver.
...
> /* OrangePi Neo 2026 (since BIOS BCPH01_V1.20), etc. */
> { "BOSC0260", (kernel_ulong_t)&bmi260_chip_info },
> + /* OneXPlayer X1 Pro (AMD), etc. */
> + { "10EC5280", (kernel_ulong_t)&bmi260_chip_info },
Yeah, this is in Realtek PCI scope which ACPI incorporates by
the specification, and yes, I have a long discussion about this
or similar IDs that are misused. If we go this way, this needs
a good shameful comment to point all this creepy choice made by
some unaware vendor(s).
Also, keep it ordered, I think this should go first in the table.
> { }
> };
See also ca2f16c31568 ("Add 10EC5280 to bmi160_i2c ACPI IDs to allow binding on some devices")
for more details.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-10 19:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 19:53 [PATCH 0/4] iio: imu: bmi270: Match PNP ID found on gaming handheld firmwares Philip Mueller
2026-07-31 19:53 ` [PATCH 1/4] iio: imu: bmi270: Match PNP ID found on OrangePi Neo 2026 Philip Mueller
2026-08-02 17:47 ` Jonathan Cameron
2026-07-31 19:53 ` [PATCH 2/4] iio: imu: bmi270: Match PNP ID found on OneXPlayer X1 Pro (AMD) Philip Mueller
2026-08-02 17:58 ` Jonathan Cameron
2026-08-10 19:04 ` Andy Shevchenko [this message]
2026-07-31 19:53 ` [PATCH 3/4] iio: imu: bmi270: add BOSC0160 PNP ID for gaming handhelds Philip Mueller
2026-08-02 18:01 ` Jonathan Cameron
2026-08-10 19:05 ` Andy Shevchenko
2026-07-31 19:53 ` [PATCH 4/4] iio: imu: bmi270: fix typo found in dc757dc Philip Mueller
2026-08-02 18:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anogpNeCbeF2UnUA@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lanzano.alex@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=philm@manjaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.