From: Keith Busch <kbusch@kernel.org>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
nilay@linux.ibm.com, Chaitanya Kulkarni <kch@nvidia.com>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3 0/5] nvme: a few error-path and validation fixes
Date: Mon, 10 Aug 2026 13:34:41 -0600 [thread overview]
Message-ID: <anon0VEOq8AApalr@kbusch-mbp> (raw)
In-Reply-To: <20260804021901.3777326-1-kanie@linux.alibaba.com>
On Tue, Aug 04, 2026 at 10:18:56AM +0800, Guixin Liu wrote:
> This series collects independent fixes found while auditing error and
> command-processing paths in the NVMe host and target drivers. Each is
> standalone; they only share the same subsystem.
>
> 1. nvmet: an Identify CNS 07h (active NS list for a command set)
> dereferences req->ns, which is always NULL on that path -> NULL
> pointer oops. Also fixes the filter to test the iterated ns->csi.
>
> 2. nvmet: nvmet_ns_enable() ignores the percpu_ref_init() return value
> and reports success to userspace when it fails, leaving the ns dead.
>
> 3. nvme-pci: the per-NUMA-node descriptor DMA pools, created lazily on
> admin tag set allocation, are only freed in nvme_remove(); a probe
> failure after that point leaks them.
>
> 4. nvme: nvme_query_fdp_info() trusts the device-supplied nruhsd count
> and can read past the fixed-size RUH status buffer (heap OOB read).
>
> 5. nvme: follow-up to #4, suggested by Kanchan -- the RUH status buffer
> and the placement handle clamp used the odd S8_MAX - 1 value; raise
> the cap to the meaningful U8_MAX (bio->bi_write_stream is u8) and
> warn on overflow.
#4 was handled by a earlier and different patch, so I dropped that one,
and patch 5 had to accomodate. I've applied the result to nvme-7.3.
prev parent reply other threads:[~2026-08-10 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 2:18 [PATCH v3 0/5] nvme: a few error-path and validation fixes Guixin Liu
2026-08-04 2:18 ` [PATCH v3 1/5] nvmet: fix NULL pointer dereference in nvmet_execute_identify_nslist() Guixin Liu
2026-08-04 2:18 ` [PATCH v3 2/5] nvmet: propagate percpu_ref_init() failure in nvmet_ns_enable() Guixin Liu
2026-08-04 2:18 ` [PATCH v3 3/5] nvme-pci: release descriptor pools on probe failure Guixin Liu
2026-08-04 2:19 ` [PATCH v3 4/5] nvme: clamp FDP placement handle count to the buffer size Guixin Liu
2026-08-04 2:19 ` [PATCH v3 5/5] nvme: raise FDP placement handle cap to U8_MAX and warn on overflow Guixin Liu
2026-08-04 16:17 ` Christoph Hellwig
2026-08-05 15:16 ` Nilay Shroff
2026-08-10 19:34 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anon0VEOq8AApalr@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.