From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56503437101 for ; Mon, 10 Aug 2026 21:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786399073; cv=none; b=pg6QokudvU104jZx6zh1oQjV3VIt5vQF5P7PadpyRJGKBaU4O898E9mjOWdBcyQ4y2DKvm8rbKuOwu56uyguSdeye+PNVmtAfuVKcRKy2O6fXmW6L8e+JN09iYiMOx9TIhsPNUSTLdYput/z9FZgFYy4/pbleP2Wg1WreWLBpDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786399073; c=relaxed/simple; bh=pn42nNZHINaa5cQbPPvQ/Xrd0sJMBFmi3IqfWzYB5Xk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LcLN70/Dzz2aaKCDZE0JqwamDXkL1ouqyR+qLW4+t8I1I1fJo6BW2Og4lfTGM995KBMADVqjRxmETa5IaMuM/fXaq+a0h1gcG9Eewx0A/8NgYk+2C/mzBKlcl7+k5WL2ioHPbHnuGY/0oQljrrrYigXRrL1Vxs2qLl34jvP6Gnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UBluJ9fU; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UBluJ9fU" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4956869750eso15546655e9.2 for ; Mon, 10 Aug 2026 14:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786399070; x=1787003870; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wO29uUqDGAT3zdZu+L3K2OaTbE4UaVPzTeBmFObh8Wo=; b=UBluJ9fUSDOsB6eIlAhig6/00BCkinh3KsuFDk7I6Obtw46OimnZ5w3DmUtnVwqk34 FlLSouUY7g8wdqD/Njla91WD3YQCBU4ib1wPPl/6MOPRGd4bCRb7mhFoP2ZfOTmbiwNK UysBlgqpO9Jo+jZNw9u+dC4xcQxXjiMlRBng8XjPcKCY2uh/QcLAt3tpwWVWqoM4JGtO 9P7sku8peWkQHRujiJ1xIq5XuFcwPFw4kNN2zh1BngCAW7YCYJEzN7v1Q3EScy1BwEzD p6C6R2zE3tCe4zI9GjmvqK7vux4lw/xFaO9QKaWnWld6Kg0BNGtn9i3+LhWjOxo20VVq AUsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786399070; x=1787003870; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wO29uUqDGAT3zdZu+L3K2OaTbE4UaVPzTeBmFObh8Wo=; b=caCNnf7tVQ36cGqG/CDfswsB3Z1bWKSz7nTTy4wRxnT1EgNirjKpChzbK8EZtRzh9X 6u26yosa4WVuSijyQ3Euyn+bxAuIzRIeI0aoLz5AzMX5NzgaAgsPh5+b/h4IUNs99qmc 5CVA/3b6FgVxXyO6Zb2cFFd4ouRkBYIJqikmfUhA5D1YTx0SoLnkv0zAWXrpAprPx+im gyUwJ0Y0upNpISGHCOl0MHdm+SNbL5hPoeLmWoJBAX88zbBWHasWBkNkJHXyopTm1Goz RK8kgis3wJlKtj+CbEW8CCQsy7QlZNBzWtU1Cv/0EDW20HarkWpe78/gm+7PiLi8g5BP 9Bhw== X-Forwarded-Encrypted: i=1; AHgh+RrLv1GRP7eOmEk5arirvOBUBllZTirrxOucWYv1G7MXttq1C9cSUjZEvPf0osecP0459eOUzM9jXz85lCI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9FfI33q2tHvZHhzPbqtilCwTP1JkCBbTof5x6kKxIKHPQ/F2Y VeCfxZ1D0hWj2OFHJ95x2ii++fyofMWUAXuv5Sk3cj946rj1fyV2VXxh X-Gm-Gg: AR+sD11rsPCWaDEClWHEh71UdDB5qbuytIDfq/fPxqYQw88+Beu9Sogm/OK8jEDVW4S 4VETpJnQ7MsceosDGgeeBG5rD+0CiHRpA4spw+BcGeTtSPu4rTnytoa1Mibd+s3xi/iBr7pYRLI a0RlThGAUxjYPkGE2A+LkHatw3M2xvmWgduvfcKUo3OoIclKLhHPmk+jJApHEljq6C0UO1oZbo6 0nvwF30U4J3SzVpurzT1F2HtMtfxwtijVAcitp3HqoeNu9N6WWCYLx+g/5NGPAjTs+HKiRPg3QG 5gV6Be3L+IBwk019BXwOF/KlhCMw+WEBx0WCQEQcsAQAcKy7ks3xVl7jXKMgueFJ6TYjs6vhGbp SNFIspuOTJN9b974CVgHko4zzvGfvCYJ9fgKNTBDrGHMOLeNmbL3KJYLTrHP5/SOFhO90e0SNiM SMDb5Z2dT7nwPVkBsXeNHYxIS/HSd1LOsQJU5oLBGv9cYdUa/08IIWbpt3jvB+nJEdf3PvQ+1tw bWRSMLCkC1YN6bCcdYKqXtJS63lI1YTzuHdN6X0emh+R9bE1P6TKvhDgmz06tbmL7yg2UrwJ2az Lq2ckwJK9l8cxX7yDLutA2tWFeAnc1+jNjKSpo3C5m2CvCuCPHejx/F1CxOJoY7hKn4MXHKg2pw rfFvDag== X-Received: by 2002:a05:600c:1906:b0:499:740c:3428 with SMTP id 5b1f17b1804b1-499740c34e4mr21608585e9.8.1786399070346; Mon, 10 Aug 2026 14:57:50 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a1e8-7401-316d-6c00-7a9a-8fac.310.pool.telefonica.de. [2a02:3100:a1e8:7401:316d:6c00:7a9a:8fac]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995c69c777sm334284955e9.2.2026.08.10.14.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 14:57:49 -0700 (PDT) Date: Mon, 10 Aug 2026 23:57:47 +0200 From: Karl Mehltretter To: Bradley Morgan Cc: Andrew Morton , Andrey Konovalov , Dmitry Vyukov , Alexander Potapenko , Marco Elver , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Juri Lelli , Vincent Guittot Subject: Re: [PATCH 5/5] sched: pause KCOV in wake_up_new_task() Message-ID: References: <20260807205027.31972-1-kmehltretter@gmail.com> <20260807205027.31972-6-kmehltretter@gmail.com> <7B5B72BA-4F48-4AB5-80B7-8ACA9F8259A7@grrlz.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7B5B72BA-4F48-4AB5-80B7-8ACA9F8259A7@grrlz.net> On Sat, Aug 08, 2026 at 02:36:11AM +0100, Bradley Morgan wrote: > I feel this comment is not the best. I mean, it's more a opinion thing. > > /* Instrumented callees would leak into current here... */ > > could be a good one. What do you think? :) > Hi Bradley, Thank you very much for the review! I agree, that's a better comment. I will send a v2 series with guard() soon. Also Sashiko's review page suggested the new flag bit could cause a UBSAN issue. That was a false positive, but it showed a cleanup opportunity: I'm changing the kcov_start() mode parameter from an enum to unsigned int, since it may contain flag bits. Thanks, Karl