All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	git@vger.kernel.org, tnyman@openai.com,
	Taylor Blau <me@ttaylorr.com>, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 2/2] ci: bump ubuntu image version for static-analysis job
Date: Tue, 11 Aug 2026 07:02:42 +0200	[thread overview]
Message-ID: <anqs8mT78znJmUwJ@pks.im> (raw)
In-Reply-To: <xmqq7blx7tii.fsf@gitster.g>

On Mon, Aug 10, 2026 at 10:52:21AM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Taking a step back, I do have to wonder whether the Cocci files have
> > been adding any kind of value in the first place. I myself introduced
> > some of them in contexts where I made sweeping changes to our APIs, so
> > that any in-flight topics can be trivially adjusted via Coccinelle. But
> > I very much doubt that anyone ever used those to adapt their in-flight
> > patch series at all.
> >
> > So maybe we should just not do that anymore?
> 
> We still do catch when somebody writes "if (a == NULL)", no?

Yes! What I was trying to say is that we maybe shouldn't add Cocci files
for temporary migrations anymore, but still keep (and extend) them for
evertyhing where we want to consistently catch antipatterns going
forward.

Overall I have a feeling that I'm overthinking this though :) Maybe it
ultimately doesn't matter too much and we just continue what we're doing
and then clean up every once in a while when too much cruft has
accumulated.

Patrick

  reply	other threads:[~2026-08-11  5:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-26  8:32 [PATCH 0/2] bump static-analysis ci image version Jeff King
2026-07-26  8:37 ` [PATCH 1/2] bloom: silence CHECK_ASSERTION_SIDE_EFFECTS false positive Jeff King
2026-07-26  8:39 ` [PATCH 2/2] ci: bump ubuntu image version for static-analysis job Jeff King
2026-08-07 10:24   ` Patrick Steinhardt
2026-08-07 16:16     ` Junio C Hamano
2026-08-10  5:38       ` Patrick Steinhardt
2026-08-10 17:52         ` Junio C Hamano
2026-08-11  5:02           ` Patrick Steinhardt [this message]
2026-08-07 16:47   ` Elijah Newren
2026-08-08 17:31   ` SZEDER Gábor
2026-07-26 16:34 ` [PATCH 0/2] bump static-analysis ci image version Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anqs8mT78znJmUwJ@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=newren@gmail.com \
    --cc=peff@peff.net \
    --cc=tnyman@openai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.