From: Breno Leitao <leitao@debian.org>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Norbert Szetei <norbert@doyensec.com>,
Taegu Ha <hataegu0826@gmail.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ppp: annotate lockless queue empty check
Date: Tue, 11 Aug 2026 02:41:17 -0700 [thread overview]
Message-ID: <anrt_vOzR6rNQdXp@gmail.com> (raw)
In-Reply-To: <20260811060236.322284-1-qingfang.deng@linux.dev>
On Tue, Aug 11, 2026 at 02:02:29PM +0800, Qingfang Deng wrote:
> ppp_poll() checks whether pf->rq contains a packet without holding the
> queue lock. skb_peek() requires appropriate locking or a private queue,
> neither of which applies because ppp_input() can enqueue concurrently.
>
> Only queue emptiness is needed, so use skb_queue_empty_lockless()
> instead.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Qingfang Deng <qingfang.deng@linux.dev>
Reviewed-by: Breno Leitao <leitao@debian.org.
next prev parent reply other threads:[~2026-08-11 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 6:02 [PATCH net] ppp: annotate lockless queue empty check Qingfang Deng
2026-08-11 9:41 ` Breno Leitao [this message]
2026-08-13 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anrt_vOzR6rNQdXp@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hataegu0826@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=norbert@doyensec.com \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.