From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84D18429802 for ; Tue, 11 Aug 2026 09:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786441362; cv=none; b=ObgxKdTs6gNLUPLU50d++u1fMOOkl7Htou4gVNtIhGhTgQ3J+IfdCdDJx5C6kWBZ84rKX3yS41dNKXLa4TUUnh7nTamEUjDaJM/9aTBeR+nG58aksa0KKlXMj2Kl+d0bQq11iw1IW/GhOdHwdpQEs4idQ/G0bZc8XJVkiD7V/uY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786441362; c=relaxed/simple; bh=CjzoQNinx/MUAJk6TYpW0pAvzThhrTgPNa2w+HqOG7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l/+iDX/+JPptmPpeb3uR4XwoIljvgnVAMWMGTbGRKbfg630eOaBdT5jKLK+1pnD1T5Jdr2IFg4sL4jKSALGI79OslCfsN9CMwTOb3R21cE4T5jstkRULwHJS1oyondMhxo98SQyq/EhnBZDkwn9+mDEXc0O9KR7drSnw661Qe3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=bLyyyKQK; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="bLyyyKQK" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-84867f07d63so3306426b3a.2 for ; Tue, 11 Aug 2026 02:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1786441361; x=1787046161; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mwCGNXF+KD6Hu7nTlnEWpPtpXjP+niM518rfogM0Juw=; b=bLyyyKQKxXWmPkDQ/cs9WEqKjXWbTOK7ibyJoaT5++E1yuzkdrSF2j2lXbPmfwStO0 VcbFD9hBBcNH0snPyapxxLg5szdF/H4Tr1KkiFzhmi2NyA4PoqflCQkwLu2XIqPQJfJ6 vge8BBJDaomss7ttEcwmK1zCrkD7wO8qEAhy0L1v6ObNZ2uu6aNszVf3aIzDIshNwFwe SZf9OhICN2fzlaMpF+UbUSZrx9ke7fKKYfnDi9pEUBcC0zP5yFW/z+LJWOdKjkAvTGSC gthsM68KWN8uXaDZ6KgXEzJgTHNlhwaiycMnDeR/erg7AVnrE3zXYdttQ6EwcpOqavhJ /I/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786441361; x=1787046161; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mwCGNXF+KD6Hu7nTlnEWpPtpXjP+niM518rfogM0Juw=; b=Stl+vXtwdJur4muLE7+af1grDHCtMUXLLXyH53YJjCwW7q1S/WfZzcrSIWIX8t8oqW /nbfehM54JKynAf1u3zWMc6mbYjI5opMRGXBycdjuJgBXzBKmIWEwqriIakJqZ7jf1QD +fn28LfCat+CIYUT21tdi8YfSELzSM8ozusHGKY7VE7RGHoGwpn5tB7eV/kWMYvwFDDO NERGTzti26TLS3z3o6EHZKpTmiNp0Y1VYRSzQBgWkyeBSHAC8/I1/+uS39pGMJ7rxcFN E52P/KNdgmNO0XjB5kk9aM7+QJAQiGQYE6fxvhTd1xlqVXDBQTGS7VUW6+V0vXJT2zL/ pnOw== X-Gm-Message-State: AOJu0Ywk0Taqvx8pS+lVOdICLhal+r2UhypI4XN+cvPgZK6Vc9t8U/No aZoklRTCYHVYeFthFwyui3+XG/YBI+pDnrW0gFc+wCOxEF60Lp6z33cxfDJZ0Qtm0Bo= X-Gm-Gg: AR+sD10+yuVjMIomU19dzMISMoRrx+imCdSwKmQUrJrbEM9w3EQ8JmornIZQCX/JOfD hBzbOgbxyYCG/AMYkv0OZl1V3wsGcuu3lD2T/q088OiWVq+pHNRbvtsnNSg0XVGsxnXkMDp0MgP fPJNg3WprxmQaFIXykcDMzJl2YifsPweSLlBzvLHzULNdEnpZ7cNWq4bpcV2K6ajJ5l9fHmcZb2 n/aTF2wxZuPpNNw024YX27BFsHfUNTDDxFgmN89W7OfMhPkApTL8ugVtgNGUnySayWbgKCiudLJ fq+J6GQbHDhHFQhqvfZLBSzXvW7LQD2g0eftxf9rpGHk+DoeXWQKNKJHn279KVtK356T3Q0DJxi JYN940SqiPE/1rwWFJWw8gH9Y6P+R8bE8/47xXjsFLUCnGoy+h4A/6DrGFoBpj1klaCSMoibBDl QUdLEg39+ztmb+EZQrSBQ4uyjMbekU1MRDgJ58329+Y+snP3u23tsqBUSH+KE= X-Received: by 2002:a05:6a00:4b15:b0:845:cdc1:a803 with SMTP id d2e1a72fcca58-84fa8694cb3mr1704052b3a.11.1786441360746; Tue, 11 Aug 2026 02:42:40 -0700 (PDT) Received: from plin-1878 ([136.226.240.195]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84fa91cdd4fsm428022b3a.23.2026.08.11.02.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:42:40 -0700 (PDT) Date: Tue, 11 Aug 2026 17:42:29 +0800 From: Yu-Chien Peter Lin To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, samuel.holland@sifive.com, dlan@kernel.org, guodong@riscstar.com, dfustini@oss.tenstorrent.com, michal.simek@amd.com, junhui.liu@pigmoral.tech, darshan.prajapati@einfochips.com, akpm@linux-foundation.org, zhangchunyan@iscas.ac.cn, luxu.kernel@bytedance.com, pincheng.plct@isrc.iscas.ac.cn, nick.hu@sifive.com, jim.shu@sifive.com, zong.li@sifive.com, greentime.hu@sifive.com, robin.randhawa@sifive.com, scott@riscstar.com, dave.patel@riscstar.com, raymond.mao@riscstar.com, anup@brainfault.org, pawandeep.oza@oss.qualcomm.com Subject: Re: [PATCH v2 3/3] dt-bindings: sifive: Add WorldGuard Checker Message-ID: References: <20260729163908.249838-1-peter.lin@sifive.com> <20260729163908.249838-4-peter.lin@sifive.com> <20260730-towering-modest-horse-ccbdcc@quoll> <20019441-9ebe-4a13-9bb5-fe1beea386ae@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20019441-9ebe-4a13-9bb5-fe1beea386ae@kernel.org> On Thu, Jul 30, 2026 at 09:37:11AM +0200, Krzysztof Kozlowski wrote: > On 30/07/2026 09:35, Krzysztof Kozlowski wrote: > >> +allOf: > >> + - $ref: /schemas/access-controllers/access-controllers.yaml# > >> + > >> +properties: > >> + compatible: > >> + oneOf: > >> + - items: > >> + - const: qemu,wgchecker2 > >> + - const: sifive,wgchecker2 > >> + - const: sifive,wgchecker2 > > > > You need soc specific compatibles. > > > > I do not believe the two review tags did any actual real review. They > > would tell you to read writing bindings document, wouldn't they? > > > And you WERE TOLD this already at v1 - missing device specific compatibles. > > Drop all review tags here, they did not happen. Understood. Best regards, Peter Lin > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6579DC5CFCF for ; Tue, 11 Aug 2026 09:42:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YsKHyPiyFLW7FfFUok4fYicYhiUB6SoxpzY+Fxey8l4=; b=bWBj7V3NZQcejd krcZPKfRZVoPqynB/738Ua5MuO9tbHHkVBqtmhGT5Lz2AMcRBdwpldWvmZp/pUO+saj1lZr92oAMT cZLnDS7TY+vUy3uAdQF5VtWE5pk4wZZGCoQCRxS7neWhUjdtVIaVyD8JpXHIhEqKy4ftSpW7afQKv /NM9QWISW3RxRKCOdhwxhBcUek5UNe7xeW0dhU7HFUlxkXnXOAbUQZmZJJeb5Fr7mXzArbIymm1Az nWk8VY5TFs4ucs8BOWRNQtEKu3cG1L++Th0Q3q4oxiL4eDmpFa7xA8PZtpKzqPM6MRBh0v2s4fVZD a1WWf/76yRcQFqpIj30g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtj0N-0000000DlxA-3wfD; Tue, 11 Aug 2026 09:42:43 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtj0L-0000000DlwP-3Lwp for linux-riscv@lists.infradead.org; Tue, 11 Aug 2026 09:42:42 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-8453427d3f4so2910716b3a.3 for ; Tue, 11 Aug 2026 02:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1786441361; x=1787046161; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mwCGNXF+KD6Hu7nTlnEWpPtpXjP+niM518rfogM0Juw=; b=aDxc/zFBanaSJFw3k7SzL1W/Y+2GR6pvs6OUUpjt5iKtnvJSanuPUUTk6/i9W9p166 nY9ZBrbK8f/KDE5PPeriEsmioSIaToBiEfvQwBdt0rRc912U9G1NKzhewo//g8RzO/Ky yF+1lkXJD/xd4YvDThQcgahXvmZeuG2qOYZD2JyaQHMX2jQXq29wshtn8BuJTm63qNg0 DvAwcunpWXU7ABqfmJlvGxkXaDqVnIUuVJPE7GcarkOyiNmGuBz6LCWvdPYyLBxbQUJA AaiWAIHP/KiZNng4gLIbPCoTJ6yeOSpQfLBPYLN2zc+kvXV8pQgnfW2neaBWx5tgR+oV X7yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786441361; x=1787046161; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mwCGNXF+KD6Hu7nTlnEWpPtpXjP+niM518rfogM0Juw=; b=pYfe5Rw5vEKtW3nzbW/+/uQ9mFIb3YBd5pLP0+jXYe0FmraVU0K2RJF6YX617QblT+ M1q3g/avBCfDith/h8IoLqOVuTu98eF7Igm4yYH2EB64/HfHppqU5COiHY33yMeHajzr Btl5wsByCEfh7Gt6doX7rkWAhYRI4RgZBtOXrYx2Baw3E1jpBrd7Y9KkQ2W/1AKgvoTK 0BRyZK79RrxArgf6gTQjQW/bGPTzfbzpTIfUcTc3swd+dWgNUpMSGbsEr0eZrrDUd8Un 0jptUMJbloS8TIJRuZciL7D8N/S6I0nD7kQYaBUnRtEsyaMbse6baum3W4w21JCW2W/Y WYnQ== X-Forwarded-Encrypted: i=1; AHgh+Rr/Gh2r6mC/m+/KJ64uo6wEPz6kqThxc6sQS6kCnxuGYc5UdoI/DN0KOwHQ6rEmZK34gJvWq57sWyzgeA==@lists.infradead.org X-Gm-Message-State: AOJu0Yz6k3bpeRm5mD15fZe6lDyJlBUXvte5wIhotcSOULp3B6Sb/Qik VeGgnPJXRyLroICGcgkSs8wmCdxv3FJnPor+2ioqdXLSswWAcpDVY1xPjjsBHvekQOs= X-Gm-Gg: AR+sD137W7M0IDB6jBVBAo4fqVPczYbWjxFPn8X1h52qySPQxQnDDYGN8WGfPTKKAhw sWRVwLEDmrbBQpEd/g36h9dVbO91lgqdbv/Ozxv0rRZrAMXwFM1HMerwoszaIpkiTt4kUe9pfdg JMNtNa5G5TxrsbLfJGu5Zx1zlYJKlPlfcRHU3eByW/zBVjNrspeSzBgY2ARI+X7+mEb9+RFMgFO muiG29cvkKy5PmjnTjCvEGGGJ/C1eqmoyR8ir1wpSpW7brsrgNnf0cqbjkzT3El3EtQGUKtdMle b9KZMZUpjQKCSYoQxlKerDYSZlcRiYVzGiRYUU5uEHmRggHX3lrYb+8qw8P7hPV7A8FK8VnRduh 5g/70eeMXsy9+HG6pFZQSTthT/5B/pGWT5PoK9e6ANb1HTqcGPdJ+qZYUi5nr3F5qeEHPTP5gWZ b4Vj3s7A3eN1t/SVDqPGgMGtcqiXdY8F827uIhbAC17UgGEOXscblOWQ+1ZFI= X-Received: by 2002:a05:6a00:4b15:b0:845:cdc1:a803 with SMTP id d2e1a72fcca58-84fa8694cb3mr1704052b3a.11.1786441360746; Tue, 11 Aug 2026 02:42:40 -0700 (PDT) Received: from plin-1878 ([136.226.240.195]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84fa91cdd4fsm428022b3a.23.2026.08.11.02.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 02:42:40 -0700 (PDT) Date: Tue, 11 Aug 2026 17:42:29 +0800 From: Yu-Chien Peter Lin To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, samuel.holland@sifive.com, dlan@kernel.org, guodong@riscstar.com, dfustini@oss.tenstorrent.com, michal.simek@amd.com, junhui.liu@pigmoral.tech, darshan.prajapati@einfochips.com, akpm@linux-foundation.org, zhangchunyan@iscas.ac.cn, luxu.kernel@bytedance.com, pincheng.plct@isrc.iscas.ac.cn, nick.hu@sifive.com, jim.shu@sifive.com, zong.li@sifive.com, greentime.hu@sifive.com, robin.randhawa@sifive.com, scott@riscstar.com, dave.patel@riscstar.com, raymond.mao@riscstar.com, anup@brainfault.org, pawandeep.oza@oss.qualcomm.com Subject: Re: [PATCH v2 3/3] dt-bindings: sifive: Add WorldGuard Checker Message-ID: References: <20260729163908.249838-1-peter.lin@sifive.com> <20260729163908.249838-4-peter.lin@sifive.com> <20260730-towering-modest-horse-ccbdcc@quoll> <20019441-9ebe-4a13-9bb5-fe1beea386ae@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20019441-9ebe-4a13-9bb5-fe1beea386ae@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260811_024241_859353_36625034 X-CRM114-Status: GOOD ( 11.95 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jul 30, 2026 at 09:37:11AM +0200, Krzysztof Kozlowski wrote: > On 30/07/2026 09:35, Krzysztof Kozlowski wrote: > >> +allOf: > >> + - $ref: /schemas/access-controllers/access-controllers.yaml# > >> + > >> +properties: > >> + compatible: > >> + oneOf: > >> + - items: > >> + - const: qemu,wgchecker2 > >> + - const: sifive,wgchecker2 > >> + - const: sifive,wgchecker2 > > > > You need soc specific compatibles. > > > > I do not believe the two review tags did any actual real review. They > > would tell you to read writing bindings document, wouldn't they? > > > And you WERE TOLD this already at v1 - missing device specific compatibles. > > Drop all review tags here, they did not happen. Understood. Best regards, Peter Lin > > Best regards, > Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv