All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linusw@kernel.org>
Cc: Yao Qi <xnorigc@gmail.com>,
	westeri@kernel.org, brgl@kernel.org, linux-gpio@vger.kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM
Date: Tue, 11 Aug 2026 17:54:29 +0300	[thread overview]
Message-ID: <ans3pcNFEDVBYXXT@ashevche-desk.local> (raw)
In-Reply-To: <anmNf3rJGxso6nuc@ashevche-desk.local>

On Mon, Aug 10, 2026 at 11:36:19AM +0300, Andy Shevchenko wrote:
> On Mon, Aug 10, 2026 at 12:17:06AM +0200, Linus Walleij wrote:
> > On Sat, Aug 8, 2026 at 9:42 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > > On Sat, Aug 08, 2026 at 03:55:13PM +0000, Yao Qi wrote:
> > 
> > > > The ASUS TX Air FA401GM experiences immediate wakeups from s2idle
> > > > (Modern Standby) when suspended with an external HDMI display connected.
> > > >
> > > > This issue is caused by spurious ACPI event signaling routed through
> > > > GPIO 24 on the AMD GPIO controller (AMDI0030:00), which triggers a
> > > > system-wide IRQ 7 (pinctrl_amd) wake-up interrupt during sleep.
> > > >
> > > > Add an ignore_wake quirk for GPIO 24 on this machine to prevent these
> > > > unwanted wakeups. This has been runtime-tested and verified using the
> > > > `gpiolib_acpi.ignore_wake=AMDI0030:00@24` kernel parameter.
> > >
> > > If AMD people will be quick enough to tag this, I will include in my PR to
> > > Linus W. on next week.
> > 
> > To Bartosz?
> > It's gpiolib...
> 
> Oh, true, I have also pin control stuff to send!

Okay, I have checked if I have anything to Bart and it seems I mixed that with
pin control stuff. So, Bart, if you feel confident about this patch, you can
take it directly. Here is my formal tag for that

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2026-08-11 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-08 15:55 [PATCH] gpiolib: acpi: Add ignore_wake quirk for ASUS TX Air FA401GM Yao Qi
2026-08-08 19:42 ` Andy Shevchenko
2026-08-09 22:17   ` Linus Walleij
2026-08-10  8:36     ` Andy Shevchenko
2026-08-11 14:54       ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ans3pcNFEDVBYXXT@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=westeri@kernel.org \
    --cc=xnorigc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.