From: Breno Leitao <leitao@debian.org>
To: Gustavo Luiz Duarte <gustavold@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/6] netconsole: reject a target mixing IPv4 and IPv6 addresses
Date: Tue, 11 Aug 2026 06:20:10 -0700 [thread overview]
Message-ID: <anshcVXKS8QqBdfM@gmail.com> (raw)
In-Reply-To: <20260810-netcons_ipv6-v2-4-3d4fc987a90f@gmail.com>
On Mon, Aug 10, 2026 at 05:47:28PM +0100, Gustavo Luiz Duarte wrote:
> The local_ip and remote_ip configfs attributes are written independently
> and nothing stops a user from mixing ipv4 and ipv6. This leads to an
> ipv4 address being zero-extended into an ipv6 header or an ipv6 address
> being truncated to its first 4 bytes for an ipv4 header.
>
> The command-line parser already refuses such a mismatch. This adds a
> similar check when a dynamic target is being enabled.
>
> Signed-off-by: Gustavo Luiz Duarte <gustavold@gmail.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2026-08-11 13:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 16:47 [PATCH net-next v2 0/6] netconsole: validate a target's IP address configuration Gustavo Luiz Duarte
2026-08-10 16:47 ` [PATCH net-next v2 1/6] netconsole: add an address family to struct inet_addr Gustavo Luiz Duarte
2026-08-11 13:11 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 2/6] netconsole: use the address family instead of the ipv6 flag Gustavo Luiz Duarte
2026-08-11 13:14 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 3/6] netconsole: reject enabling a target with no remote IP address Gustavo Luiz Duarte
2026-08-11 13:16 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 4/6] netconsole: reject a target mixing IPv4 and IPv6 addresses Gustavo Luiz Duarte
2026-08-11 13:20 ` Breno Leitao [this message]
2026-08-10 16:47 ` [PATCH net-next v2 5/6] netconsole: show empty string for an unset IP address Gustavo Luiz Duarte
2026-08-11 13:21 ` Breno Leitao
2026-08-10 16:47 ` [PATCH net-next v2 6/6] netconsole: move struct inet_addr into netconsole.c Gustavo Luiz Duarte
2026-08-11 13:21 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anshcVXKS8QqBdfM@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.