From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Nikolay Kulikov <nikolayof23@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] staging: media: atomisp: inline macros for checking the bo/bodev pointer
Date: Wed, 12 Aug 2026 10:52:52 +0300 [thread overview]
Message-ID: <anwmVELbwVshXGzg@ashevche-desk.local> (raw)
In-Reply-To: <anwleCB7QFRPfY-t@ashevche-desk.local>
On Wed, Aug 12, 2026 at 10:49:17AM +0300, Andy Shevchenko wrote:
> On Thu, Jul 23, 2026 at 09:51:19PM +0300, Nikolay Kulikov wrote:
...
> > struct hmm_buffer_object *hmm_bo_alloc(struct hmm_bo_device *bdev,
> > unsigned int pgnr)
> > {
> > struct hmm_buffer_object *bo, *new_bo;
> > - struct rb_root *root = &bdev->free_rbtree;
> > + struct rb_root *root;
> > +
> > + if (!bdev) {
> > + dev_err(atomisp_dev, "NULL hmm_bo_device.\n");
> > + return NULL;
> > + }
> >
> > - check_bodev_null_return(bdev, NULL);
> > + root = &bdev->free_rbtree;
> > var_equal_return(hmm_bo_device_inited(bdev), 0, NULL,
> > "hmm_bo_device not inited yet.\n");
>
> While at it, also replace here var_equal_return() with appropriate C code.
Ah, it's done in the last patch!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-12 7:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:51 [PATCH v2 0/4] staging: media: atomisp: cleanup pci/hmm/ code Nikolay Kulikov
2026-07-23 18:51 ` [PATCH v2 1/4] staging: media: atomisp: remove unused functions from pci/hmm/ Nikolay Kulikov
2026-08-12 7:49 ` Andy Shevchenko
2026-07-23 18:51 ` [PATCH v2 2/4] staging: media: atomisp: inline macros for checking the bo/bodev pointer Nikolay Kulikov
2026-08-12 7:49 ` Andy Shevchenko
2026-08-12 7:52 ` Andy Shevchenko [this message]
2026-07-23 18:51 ` [PATCH v2 3/4] staging: media: atomisp: inline the check_bo_status_*() macros Nikolay Kulikov
2026-08-12 7:51 ` Andy Shevchenko
2026-07-23 18:51 ` [PATCH v2 4/4] staging: media: atomisp: remove include/hmm/hmm_common.h file Nikolay Kulikov
2026-08-12 7:56 ` Andy Shevchenko
2026-08-12 17:22 ` Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anwmVELbwVshXGzg@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nikolayof23@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.