All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: Peter Fang <peter.fang@intel.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>,  "bp@alien8.de" <bp@alien8.de>,
	"kas@kernel.org" <kas@kernel.org>,
	 "binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	 "mingo@redhat.com" <mingo@redhat.com>,
	 "sathyanarayanan.kuppuswamy@linux.intel.com"
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	 "x86@kernel.org" <x86@kernel.org>,
	"tglx@kernel.org" <tglx@kernel.org>,
	 "linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	Artem Bityutskiy <artem.bityutskiy@intel.com>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic
Date: Wed, 12 Aug 2026 16:10:39 -0700	[thread overview]
Message-ID: <anz9b6CDkhr5D5RG@google.com> (raw)
In-Reply-To: <6191a69559e58e04c8e3f1efa776e9639796af3d.camel@intel.com>

On Wed, Aug 12, 2026, Rick P Edgecombe wrote:
> On Wed, 2026-08-12 at 15:37 -0700, Peter Fang wrote:
> > > 
> > > But part of this too, is that "DICE" is an industry standard [0]. Some of
> > > the existing TDX attestation format is TDX specific, and moving to the
> > > standard is expected to make the verifier better. So TDX does not have full
> > > flexibility in choosing which bits go where. There is some. But I'm not sure
> > > which.
> > 
> > In the SGX era, a lot of this attestation stuff was Intel proprietary
> > and that caused a lot of pain. To follow the DICE standard the bits in
> > the report have specific places to go inside the quote blob. IOW the
> > DICE quote doesn't just carry the report like an attachment, and so the
> > two can't be separated (not without breaking the standard in some way).
> 
> Yea that was my suspicion. I'm not sure if separating them was really Sean's
> understanding or not. 

LOL, most definitely not.  Though I have a naive question at this point: why can't
the TDX-Module extract the bits from the report and put them in the right places
when generating the quote?

> But the other part is that the verifiers and other VMM infrastructures are
> already expecting this standard format. It would have a lot of downsides.
> 
> But the "grow the report" or "grow the report and quote" are still options that
> leave the quote in the expected DICE format, right? Sean I'll assume you still
> prefer the "grow both" option for the sake of kicking the quoting
> responsibilities out of KVM.

Not necessarily.  If doing the right thing from a "what's intended and sane"
perspective is to put some quoting responsibilities on KVM, then so be it.  But
I would like to have a passing understanding of what all is going on, if only so
that I can justify why the new uAPI is being added when I send Paolo a pull
request.  I'm pushing back purely because I quite literally don't understand why
KVM needs to be involved.

  reply	other threads:[~2026-08-12 23:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 12:29 [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic Peter Fang
2026-07-29 12:29 ` [PATCH v3 1/4] x86/tdx: Add helper to query maximum TD Quote size Peter Fang
2026-07-29 12:29 ` [PATCH v3 2/4] virt: tdx-guest: Calculate the Quote buffer size safely Peter Fang
2026-07-29 18:29   ` Kuppuswamy Sathyanarayanan
2026-07-29 12:29 ` [PATCH v3 3/4] virt: tdx-guest: Use a variable to store the Quote buffer size Peter Fang
2026-07-29 12:58   ` sashiko-bot
2026-07-29 18:47   ` Kuppuswamy Sathyanarayanan
2026-07-29 12:29 ` [PATCH v3 4/4] virt: tdx-guest: Allocate Quote buffer dynamically Peter Fang
2026-07-29 12:55   ` sashiko-bot
2026-07-29 21:21 ` [PATCH v3 0/4] tdx-guest: Make Quote buffer size dynamic Edgecombe, Rick P
2026-08-11 22:40   ` Edgecombe, Rick P
2026-08-12 14:08     ` Sean Christopherson
2026-08-12 16:02       ` Edgecombe, Rick P
2026-08-12 16:43         ` Sean Christopherson
2026-08-12 17:22           ` Edgecombe, Rick P
2026-08-12 22:37             ` Peter Fang
2026-08-12 22:47               ` Edgecombe, Rick P
2026-08-12 23:10                 ` Sean Christopherson [this message]
2026-08-12 23:30                   ` Edgecombe, Rick P
2026-08-12 23:27                 ` Peter Fang
2026-08-12 21:02         ` Peter Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anz9b6CDkhr5D5RG@google.com \
    --to=seanjc@google.com \
    --cc=artem.bityutskiy@intel.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-coco@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peter.fang@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.