From: Keith Busch <kbusch@kernel.org>
To: Xixin Liu <liuxixin@kylinos.cn>
Cc: linux-nvme@lists.infradead.org, axboe@kernel.dk, hch@lst.de,
sagi@grimberg.me, linux-kernel@vger.kernel.org, hare@kernel.org,
shinichiro.kawasaki@wdc.com
Subject: Re: [PATCH] nvme-tcp: defer TLS inline send to io_work
Date: Mon, 24 Aug 2026 20:57:50 -0600 [thread overview]
Message-ID: <ao0ErlDKMbvwAoGx@kbusch-mbp> (raw)
In-Reply-To: <c6e2a91f0b62.1787100300.git.liuxixin@kylinos.cn>
On Wed, Aug 19, 2026 at 08:50:00AM +0800, Xixin Liu wrote:
> blk_mq holds set->srcu while queuing and running requests. The kTLS
> software send path takes ctx->tx_lock. lockdep knows that tx_lock
> nests under elevator_lock which then waits on srcu, so an inline
> send from that path under TLS triggers circular locking.
>
> Skip the inline send optimization for TLS queues so the send runs
> from the workqueue instead. The same workqueue already retries TLS
> sends on write-space notifications. Plain TCP keeps the inline path.
Thanks, applied to nvme-7.3.
For future, could you please send new patches as new threads separate
from the discussion that spawned them? You can use "Link:" tags for
prior discussion if you want to keep it, but this interleaving and
changing subjects in the same thread is a bit unpleasant for tracking
purposes.
next prev parent reply other threads:[~2026-08-25 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 5:04 blktests failures with v7.1 kernel Shin'ichiro Kawasaki
2026-06-26 1:19 ` blktests nvme/062 lockdep — defer TLS inline send to io_work? Xixin Liu
2026-06-26 6:40 ` Hannes Reinecke
2026-06-29 7:00 ` Xixin Liu
2026-07-01 1:50 ` Xixin Liu
2026-08-18 5:38 ` Shin'ichiro Kawasaki
2026-08-18 12:34 ` Hannes Reinecke
2026-08-19 0:50 ` [PATCH] nvme-tcp: defer TLS inline send to io_work Xixin Liu
2026-08-25 2:57 ` Keith Busch [this message]
2026-08-26 0:45 ` Xixin Liu
2026-08-19 1:05 ` blktests nvme/062 lockdep, defer TLS inline send to io_work? Xixin Liu
2026-08-22 23:02 ` blktests nvme/062 lockdep — " Sagi Grimberg
2026-08-24 6:00 ` blktests nvme/062 lockdep, " Xixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao0ErlDKMbvwAoGx@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=liuxixin@kylinos.cn \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.