All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Tao Cui <cui.tao@linux.dev>
Cc: tj@kernel.org, void@manifault.com, changwoo@igalia.com,
	suzhidao@xiaomi.com, sched-ext@lists.linux.dev,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
	Tao Cui <cuitao@kylinos.cn>
Subject: Re: [PATCH v3 0/2] sched_ext: pass the initial cpu.idle state in scx_cgroup_init_args
Date: Tue, 25 Aug 2026 07:51:57 +0200	[thread overview]
Message-ID: <ao0tfbNNcs514WgU@gpd4> (raw)
In-Reply-To: <20260825023557.27881-1-cui.tao@linux.dev>

On Tue, Aug 25, 2026 at 10:35:55AM +0800, Tao Cui wrote:
> From: Tao Cui <cuitao@kylinos.cn>
> 
> This carries the initial cpu.idle state of a cgroup through
> ops.cgroup_init(), which was the only cpu controller knob whose
> initial value never reached the BPF scheduler. Patch 1 is the fix;
> patch 2 renames tg->scx.idle to tg->scx.sched_idle, suggested in
> review, as a separate cleanup.

This looks good to me.

Reviewed-by: Andrea Righi <arighi@nvidia.com>

Thanks,
-Andrea

> 
> Changes since v2:
> 
> - rename the new field to sched_idle, as a bare "idle" reads as CPU
>   idle state in sched_ext (Tejun)
> - split the tg->scx.idle rename into 2/2 so 1/2 stays minimal for
>   stable backport
> - add the Fixes: tag (Andrea)
> - regenerate on top of current linux-next, which also resolves the CI
>   conflict reported against v2
> 
> v2: https://lore.kernel.org/r/20260824142817.568085-1-cui.tao@linux.dev
> v1: https://lore.kernel.org/r/20260824133954.561956-1-cui.tao@linux.dev
> 
> Tao Cui (2):
>   sched_ext: pass the initial cpu.idle state in scx_cgroup_init_args
>   sched_ext: rename tg->scx.idle to tg->scx.sched_idle
> 
>  include/linux/sched/ext.h   | 2 +-
>  kernel/sched/ext/ext.c      | 8 +++++---
>  kernel/sched/ext/internal.h | 3 +++
>  kernel/sched/ext/sub.c      | 2 ++
>  4 files changed, 11 insertions(+), 4 deletions(-)
> 
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2026-08-25  5:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  2:35 [PATCH v3 0/2] sched_ext: pass the initial cpu.idle state in scx_cgroup_init_args Tao Cui
2026-08-25  2:35 ` [PATCH v3 1/2] " Tao Cui
2026-08-25  2:35 ` [PATCH v3 2/2] sched_ext: rename tg->scx.idle to tg->scx.sched_idle Tao Cui
2026-08-25  5:20   ` Tao Cui
2026-08-25  5:51 ` Andrea Righi [this message]
2026-08-31 21:59 ` [PATCH v3 0/2] sched_ext: pass the initial cpu.idle state in scx_cgroup_init_args Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao0tfbNNcs514WgU@gpd4 \
    --to=arighi@nvidia.com \
    --cc=bpf@vger.kernel.org \
    --cc=changwoo@igalia.com \
    --cc=cui.tao@linux.dev \
    --cc=cuitao@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sched-ext@lists.linux.dev \
    --cc=suzhidao@xiaomi.com \
    --cc=tj@kernel.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.