Re: [PATCH v3 1/3] module: add SCMI device table alias support

["Uwe Kleine-König" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]

Hello Hans,

On Mon, Aug 24, 2026 at 04:58:43PM +0200, Hans de Goede wrote:
> On 24-Aug-26 14:22, Uwe Kleine-König wrote:
> > Hello,
> > 
> > I just replied to v2 and only then found out there is a v3 already.
> > There is something wrong with my mail filtering, sorry.
> 
> Not sure if it is your filtering, v2 is somewhat old
> and I only just revived this series.
> 
> I'll add you to the Cc list for v4.

If you don't make the mess that is mod_devicetable.h worse, there is no
need. I'm already overwhelmed with mail ...

> >> +};
> >> +
> >> +#endif /* ifndef LINUX_DEVICE_ID_SCMI_H */
> >> diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> >> index a397213bedac..d241421c36aa 100644
> >> --- a/include/linux/mod_devicetable.h
> >> +++ b/include/linux/mod_devicetable.h
> >> @@ -49,6 +49,7 @@
> >>  #include "device-id/pnp.h"
> >>  #include "device-id/rio.h"
> >>  #include "device-id/rpmsg.h"
> >> +#include "device-id/scmi.h"
> > 
> > Please don't add new includes to mod_devicetable.h. That header is ugly
> > and each include makes it worse. Just add <linux/device-id/scmi.h> to
> > the modpost source.
> 
> Hmm, I did that at first, but that is quite ugly also because
> file2alias.c, does:
> 
> #include "../../include/linux/mod_devicetable.h"
> 
> So I ended up needing to change that to:
> 
> #include "../../include/linux/device-id/scmi.h"
> #include "../../include/linux/mod_devicetable.h"
> 
> my thinking was that the purpose would be to move other
> consumers of mod_devicetable.h to directly include
> linux/device-id/*.h"
> 
> And keep mod_devicetable.h as a file which includes all
> of them for use in devicetable-offsets.c + file2alias.c
> 
> But I can see how actually getting there will be a long time
> in the making and in the mean time this will cause longer
> compile times.

Yeah, I'm still pondering a bit if I should start dropping #includes
from mod_devicetable.h or if that is more annoying. Fighting new
includers for mod_devicetable.h itself seems to be a tough task, too.

> So if you're saying the somewhat ugly thing of adding
> linux/device-id/scmi.h directly to devicetable-offsets.c +
> file2alias.c is the right thing to do, then I'm happy to
> do that for v4.
> 
> If I'm reading your comment correctly, that is what you
> want me to do, right ?

Yes. I agree it's not pretty, but IMHO better bearable.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]