From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01729C61DB6 for ; Tue, 25 Aug 2026 09:31:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wynUU-0004KX-Uq; Tue, 25 Aug 2026 05:30:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wynUT-0004Hq-F0 for qemu-devel@nongnu.org; Tue, 25 Aug 2026 05:30:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wynUR-00033B-E9 for qemu-devel@nongnu.org; Tue, 25 Aug 2026 05:30:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787650241; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eQ2N6U4Ve/hqMwyfoUgqlNuT8vEk7ZbXZjs0N7jkytI=; b=VZ3X48zsH6mRBXlAMCJrnAUC3KVwo0hBia/ZMoDXhdSfaSxLfnTX+TmKb2FzeYoG+Xpumy qP2z2rMycQuXWZZlcjankdS9Ff3YTSY/f2uGt+fTIQ1xakDSc1CmCvMZwJbjgSydeR/8NY 4l/fmpTSsxofYun3/16Qvi2os+xoxPQ= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-TuevsnqYMrKzOcgB9EkFHQ-1; Tue, 25 Aug 2026 05:30:38 -0400 X-MC-Unique: TuevsnqYMrKzOcgB9EkFHQ-1 X-Mimecast-MFC-AGG-ID: TuevsnqYMrKzOcgB9EkFHQ_1787650237 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7258A186A712; Tue, 25 Aug 2026 09:30:37 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 21F5530002EE; Tue, 25 Aug 2026 09:30:35 +0000 (UTC) Date: Tue, 25 Aug 2026 10:30:32 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org Subject: Re: [PATCH] hw/misc: fix trace-events Message-ID: References: <20260825074114.853069-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260825074114.853069-1-marcandre.lureau@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Aug 25, 2026 at 11:41:14AM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > The commit 8041d1730871 accidentally removed the vmlaunchupdate.c > trace events. More importantly CI failed to report that build failure. IIUC, this is likely due to missing libigvm library. We have this available in Fedora at least, not sure about other distros, but we can add igvm to libvirt-ci and then to QEMU's deps list for CI. > > Fixes: 8041d1730871 ("tests/qtest: add test for K230 gsdma") > Signed-off-by: Marc-André Lureau > --- > hw/misc/trace-events | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/hw/misc/trace-events b/hw/misc/trace-events > index 16db4ba0cc17..0b8be3d0f226 100644 > --- a/hw/misc/trace-events > +++ b/hw/misc/trace-events > @@ -446,3 +446,9 @@ iommu_testdev_dma_armed(bool armed) "armed=%d" > # k230_decomp_gzip.c > k230_decomp_gzip_read(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP read: [0x%"PRIx64"] size %u -> 0x%"PRIx64 > k230_decomp_gzip_write(uint64_t offset, unsigned int size, uint64_t value) "K230 DECOMP GZIP write: [0x%"PRIx64"] size %u <- 0x%"PRIx64 > + > +# vmlaunchupdate.c > +launch_update_write(void) "" > +vmlaunch_reset_enter(void) "" > +vm_launchupdate_finalize(void) "" > +restore_host_x86_igvm(void) "" > -- > 2.55.0.543.g5ebe2ebe4ea8 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|