From: Florian Westphal <fw@strlen.de>
To: Jiri Peska <jpeska@redhat.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] tests: shell: Add coverage for nf_connlabels_replace()
Date: Tue, 25 Aug 2026 12:45:26 +0200 [thread overview]
Message-ID: <ao1yRhyaA6_cfbsR@strlen.de> (raw)
In-Reply-To: <20260825102429.173237-1-jpeska@redhat.com>
Jiri Peska <jpeska@redhat.com> wrote:
> Signed-off-by: Jiri Peska <jpeska@redhat.com>
> ---
> tests/shell/testcases/packetpath/ct_label_set | 27 ++++
> .../packetpath/dumps/ct_label_set.json-nft | 132 ++++++++++++++++++
> .../packetpath/dumps/ct_label_set.nft | 11 ++
> 3 files changed, 170 insertions(+)
> create mode 100755 tests/shell/testcases/packetpath/ct_label_set
> create mode 100644 tests/shell/testcases/packetpath/dumps/ct_label_set.json-nft
> create mode 100644 tests/shell/testcases/packetpath/dumps/ct_label_set.nft
This fails for me in dump validation, diff is:
- icmp type echo-request ip daddr 127.0.0.1 ct label set 1
- icmp type echo-request ip daddr 127.0.0.1 ct label 1 counter name "labeled"
+ icmp type echo-request ip daddr 127.0.0.1 ct label set "bar"
+ icmp type echo-request ip daddr 127.0.0.1 ct label "bar" counter name "labeled"
This is caused by local configuration. I'd remove the dump files here
before applying (and add a nodump file instead).
As the test explicitly checks counters in the script, it will still be
useful to assert match/nomatch.
What do you think?
prev parent reply other threads:[~2026-08-25 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 10:24 [PATCH nft] tests: shell: Add coverage for nf_connlabels_replace() Jiri Peska
2026-08-25 10:45 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao1yRhyaA6_cfbsR@strlen.de \
--to=fw@strlen.de \
--cc=jpeska@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.