From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC28FC61DBD for ; Tue, 25 Aug 2026 11:55:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wypk9-0001yG-PV; Tue, 25 Aug 2026 07:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wypk8-0001tx-KI for qemu-devel@nongnu.org; Tue, 25 Aug 2026 07:55:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wypk7-0001p9-1V for qemu-devel@nongnu.org; Tue, 25 Aug 2026 07:55:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787658901; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DEgTfsDLFMWSrDTm03jNmDshxbXehrglD0t4maYMh9Y=; b=QuOLHG4nVIAvCgBIhdh/wt10HhM2tge9+/4xcek9EbOPrvz8VE+6VZClUJOHICY6VzYXaD zC6UvSVxp4yQE47Pimk5Bf/bpy3jLj8kqJFx56lvG07EdXj7lgXheTWvmEtJXStY8uMGTN LzSo+2LUQ+21SrzcJ55+2oir0AYYnJE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-Nuxt0LBINNi-9N5ZipGjVw-1; Tue, 25 Aug 2026 07:54:56 -0400 X-MC-Unique: Nuxt0LBINNi-9N5ZipGjVw-1 X-Mimecast-MFC-AGG-ID: Nuxt0LBINNi-9N5ZipGjVw_1787658895 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 02B441978F71; Tue, 25 Aug 2026 11:54:55 +0000 (UTC) Received: from redhat.com (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D3481955F08; Tue, 25 Aug 2026 11:54:53 +0000 (UTC) Date: Tue, 25 Aug 2026 12:54:50 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-stable@nongnu.org Cc: qemu-devel@nongnu.org, richard.henderson@linaro.org Subject: Re: [GIT PULL 06/19] crypto: fix build against nettle >= 4 Message-ID: References: <20260825-fixes-v1-0-c59e8a620836@redhat.com> <20260825-fixes-v1-6-c59e8a620836@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260825-fixes-v1-6-c59e8a620836@redhat.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org CC qemu-stable - can pick this into historical branches so they build with latest nettle. On Tue, Aug 25, 2026 at 03:20:56PM +0400, Marc-André Lureau wrote: > sha.h has been deprecated. It seems we can rely on sha1.h/sha2.h > since we depend on >= 3.7.3. > > Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4184 > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Marc-André Lureau > --- > crypto/hash-nettle.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/crypto/hash-nettle.c b/crypto/hash-nettle.c > index 53f68301efb5..2589bbf4c10e 100644 > --- a/crypto/hash-nettle.c > +++ b/crypto/hash-nettle.c > @@ -24,7 +24,8 @@ > #include "crypto/hash.h" > #include "hashpriv.h" > #include > -#include > +#include > +#include > #include > #ifdef CONFIG_CRYPTO_SM3 > #include > > -- > 2.55.0.543.g5ebe2ebe4ea8 > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|