From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D29128E0F for ; Wed, 26 Aug 2026 00:11:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787703112; cv=none; b=e2HcOGX5EXRIxh0BUkj27WeZZZyZ/Fq1sE0szAt62UOiei69qCK2fA3biqig/KKY/wqF8aLcXWDYMtbrCaYcV1BfxIW/nOeUtoER7Qr7UVozQQgT5C33GpByVPTHWyZg/G6lMftBVWk/Yb3JYj1W+MrwsSe1LxX7VIKdmV86vrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787703112; c=relaxed/simple; bh=+Z+8bVvj1iPk5OxPpHR3vQ4YbkoOtXd4K9HdJKeXaRo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HZNLvxGd41SAIuXjyLAkXAH74c7MJolwigdN9KwHllAKEGC9ZgDV/eJ5kUivucC7mNGWcqoJho/hRqXD14vk3NrT4p1UtoIFTeNz4ooExSsnPQBMlVnAwNjUNVQItPO+XH6JhzxwAKJn5fYGjvhoJvRTEGxW55JFW/XkBGPnfck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N5fpd6Rf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N5fpd6Rf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7F2B1F000E9; Wed, 26 Aug 2026 00:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787703110; bh=2PS5KY70aNJyYqPvv5fmig/NRtw70HPD+C2S9bEerrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=N5fpd6Rf/upogpV5TCcxunEhA+S5ObAt1XTZvsaXFujQMe796bLGj03+5vZ53o+ol kfCOV5jrhDU8WYEjQy2p4CVCKrik93hh8+n/KRuTIJJszYawuVdy4pYVbsK/vii4I6 yqcmnt+zrAfY7V9OL+2CXbEqUSngxfLh9EkkQcTDZtp1zz9FxaaPr0sCpSUK7GY3n4 eafGgYM92ImotfYIfpl2X15IgGPpkV4Px/suGCwKj1xAyUupSlykqfMHOZkr8PjNx4 Tqh2nm3aGAARvV0/XTFARe15xFP7SkREkRGggloDWg8r8+cKehAdTdpje/K6UvOD85 HKsoo2zikrhAw== Date: Wed, 26 Aug 2026 00:11:49 +0000 From: Jaegeuk Kim To: Wenjie Qi Cc: chao@kernel.org, qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked Message-ID: References: <20260818200121.2684318-1-jaegeuk@kernel.org> <20260825023925.230986-1-qiwenjie@xiaomi.com> <20260825173111.1151141-1-qiwenjie@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260825173111.1151141-1-qiwenjie@xiaomi.com> On 08/26, Wenjie Qi wrote: > Hi Jaegeuk, > > Yes, that's true for the normal path. > > What I meant is the rollback case: err is non-zero, but __do_unlink() > may still return ret == 0. If the preceding f2fs_add_link() has already > been checkpointed, a crash before the rollback deletion is checkpointed > could expose the incomplete symlink again. Should we run f2fs_sync_fs() > for !ret && IS_DIRSYNC(dir), while preserving err? I get the point, but I feel that we don't really need to guarantee unlink, since we're going to return an error anyways? > > Regards, > Wenjie > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F32F7C61DB9 for ; Wed, 26 Aug 2026 00:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fDKQOaPodKhEynXG4s9B3Ipbsc8XfB9soem3prlFLts=; b=i1aXi7DxUOBK6niFvwQurVKnGZ etBGwhGe0PrXYdaK1QOP+Qr4qidUcHkZUf53zrB9oYhUAycwJfPhgVsL+UiBvk7070vNOIPQr+BbA STo29lKJx/khZ/ATc8p10TodGKWjU/IVJRpCOG/VGYjFWp/o9ZY1aTKibUjj3NVWC8rI=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wz1FG-00085Q-L7; Wed, 26 Aug 2026 00:11:59 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wz1FE-00085I-Ft for linux-f2fs-devel@lists.sourceforge.net; Wed, 26 Aug 2026 00:11:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2PS5KY70aNJyYqPvv5fmig/NRtw70HPD+C2S9bEerrI=; b=UwzCxZ7IAnav2k0zWL/nJ1AS2Q apNffIAoVhb2t4ufHoko7PMUmz8vzrNSNALTTnnvFpn/6wQBk0oPJ3MqOrUHIb6NF84rwMmXsEhLH Pm/srf4o98EORlfHQBkyLyMQZu9tEL6l+jqD+oYUrQ/en/TpoaXtPxpbNoGt+jIlDaqc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2PS5KY70aNJyYqPvv5fmig/NRtw70HPD+C2S9bEerrI=; b=mfo2X+RDc5ZHZQ/7w9+Gb13DdB 1sZs/H98WoYxNUjVHlrxzBfVCsqwbJt24gQZFwtPk4GZitfrGdlnr2QQK+PQ35YZgYKubuHmTfCx/ Ea+m0VSFVQXg0jYlPQJL+KTUkgOVyk7jUOce1JAfrGR3rTyzqzI7d0j+pwSc4/SOUeXM=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wz1FE-0007j6-GF for linux-f2fs-devel@lists.sourceforge.net; Wed, 26 Aug 2026 00:11:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id F234541B67; Wed, 26 Aug 2026 00:11:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7F2B1F000E9; Wed, 26 Aug 2026 00:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787703110; bh=2PS5KY70aNJyYqPvv5fmig/NRtw70HPD+C2S9bEerrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=N5fpd6Rf/upogpV5TCcxunEhA+S5ObAt1XTZvsaXFujQMe796bLGj03+5vZ53o+ol kfCOV5jrhDU8WYEjQy2p4CVCKrik93hh8+n/KRuTIJJszYawuVdy4pYVbsK/vii4I6 yqcmnt+zrAfY7V9OL+2CXbEqUSngxfLh9EkkQcTDZtp1zz9FxaaPr0sCpSUK7GY3n4 eafGgYM92ImotfYIfpl2X15IgGPpkV4Px/suGCwKj1xAyUupSlykqfMHOZkr8PjNx4 Tqh2nm3aGAARvV0/XTFARe15xFP7SkREkRGggloDWg8r8+cKehAdTdpje/K6UvOD85 HKsoo2zikrhAw== Date: Wed, 26 Aug 2026 00:11:49 +0000 To: Wenjie Qi Message-ID: References: <20260818200121.2684318-1-jaegeuk@kernel.org> <20260825023925.230986-1-qiwenjie@xiaomi.com> <20260825173111.1151141-1-qiwenjie@xiaomi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260825173111.1151141-1-qiwenjie@xiaomi.com> X-Headers-End: 1wz1FE-0007j6-GF Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jaegeuk Kim via Linux-f2fs-devel Reply-To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08/26, Wenjie Qi wrote: > Hi Jaegeuk, > > Yes, that's true for the normal path. > > What I meant is the rollback case: err is non-zero, but __do_unlink() > may still return ret == 0. If the preceding f2fs_add_link() has already > been checkpointed, a crash before the rollback deletion is checkpointed > could expose the incomplete symlink again. Should we run f2fs_sync_fs() > for !ret && IS_DIRSYNC(dir), while preserving err? I get the point, but I feel that we don't really need to guarantee unlink, since we're going to return an error anyways? > > Regards, > Wenjie > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel