All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"michal.simek@amd.com" <michal.simek@amd.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"git@amd.com" <git@amd.com>
Subject: Re: [PATCH 0/5] usb: dwc3: xilinx: error handling and teardown fixes
Date: Wed, 26 Aug 2026 00:22:38 +0000	[thread overview]
Message-ID: <ao4xQgvplTIFQk7K@vbox> (raw)
In-Reply-To: <20260810174713.2325292-1-radhey.shyam.pandey@amd.com>

On Mon, Aug 10, 2026, Radhey Shyam Pandey wrote:
> This series improves error handling, resource teardown, and system sleep
> PM robustness in the dwc3-xilinx glue driver for ZynqMP and Versal
> platforms.
> 
> Patch 1 switches probe to device_get_match_data() and adds the direct
> property.h include instead of relying on of.h for that helper.
> 
> Patch 2 introduces struct dwc3_xlnx_platdata and moves ZynqMP and
> Versal setup behind plat->init(). The struct also defines an exit
> callback slot used by the later teardown patches.
> 
> Patch 3 fixes system suspend and resume PHY handling: suspend now
> powers off the PHY before phy_exit() and propagates errors; resume
> disables clocks if PHY reinitialization fails after they were enabled.
> 
> Patch 4 fixes ZynqMP init error paths. Reset handles are saved in
> driver private data and fall-through error labels re-assert only the
> resets already released before unwinding the PHY when init fails
> partway through reset deassert or PHY setup.
> 
> Patch 5 adds dwc3_xlnx_exit_zynqmp(), wires it as the ZynqMP platform
> exit callback, and calls plat->exit() from probe error paths after a
> successful plat->init() and from remove()/shutdown.
> 
> Radhey Shyam Pandey (5):
>   usb: dwc3: xilinx: use device_get_match_data() in probe
>   usb: dwc3: xilinx: add platform data struct with init callback
>   usb: dwc3: xilinx: fix system suspend and resume PHY handling
>   usb: dwc3: xilinx: re-assert resets on ZynqMP init error paths
>   usb: dwc3: xilinx: unwind ZynqMP platform init on probe failure and
>     remove
> 
>  drivers/usb/dwc3/dwc3-xilinx.c | 132 +++++++++++++++++++++++++--------
>  1 file changed, 100 insertions(+), 32 deletions(-)
> 
> 
> base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
> -- 
> 2.43.0
> 

These patches look good to me, do you plan to backport the fixes? If so,
can you Cc stable and re-order them so that the fixes patches go first?
Better yet, keep the fixes and new changes in separate series.

Thanks,
Thinh

  parent reply	other threads:[~2026-08-26  0:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 17:47 [PATCH 0/5] usb: dwc3: xilinx: error handling and teardown fixes Radhey Shyam Pandey
2026-08-10 17:47 ` [PATCH 1/5] usb: dwc3: xilinx: use device_get_match_data() in probe Radhey Shyam Pandey
2026-08-26  0:09   ` Thinh Nguyen
2026-08-10 17:47 ` [PATCH 2/5] usb: dwc3: xilinx: add platform data struct with init callback Radhey Shyam Pandey
2026-08-10 17:47 ` [PATCH 3/5] usb: dwc3: xilinx: fix system suspend and resume PHY handling Radhey Shyam Pandey
2026-08-26  0:12   ` Thinh Nguyen
2026-08-10 17:47 ` [PATCH 4/5] usb: dwc3: xilinx: re-assert resets on ZynqMP init error paths Radhey Shyam Pandey
2026-08-10 17:47 ` [PATCH 5/5] usb: dwc3: xilinx: unwind ZynqMP platform init on probe failure and remove Radhey Shyam Pandey
2026-08-26  0:22 ` Thinh Nguyen [this message]
2026-09-01 14:10   ` [PATCH 0/5] usb: dwc3: xilinx: error handling and teardown fixes gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao4xQgvplTIFQk7K@vbox \
    --to=thinh.nguyen@synopsys.com \
    --cc=git@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=p.zabel@pengutronix.de \
    --cc=radhey.shyam.pandey@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.