From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: mdshahid03@gmail.com, "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] iio: adc: bcm_iproc_adc: sort headers alphabetically
Date: Wed, 26 Aug 2026 11:26:41 +0300 [thread overview]
Message-ID: <ao6jQaJc9FokuK6A@ashevche-desk.local> (raw)
In-Reply-To: <ao5dVuReF1Q63ccU@debian-BULLSEYE-live-builder-AMD64>
On Wed, Aug 26, 2026 at 12:28:22AM -0300, Marcelo Schmitt wrote:
> On 08/25, mdshahid03@gmail.com wrote:
...
> The sorting looks okay to me. Though, there are some includes missing and a
> couple of them that don't seem to be needed (delay.h and io.h). Either in
> replacement of this patch or as a follow on extra patch (not sure how maintainers
> would like to have it in this case),
Too many lines to sort, hence separate patch:
- sort
- apply IWYU
> it would be nice to also update the include list according to
> include-what-you-use principles.
> If you decide to work on the update to make it iwyu compliant, it may be
> helpful to set an IIO tailored mapping file such as the one shared by Jonathan
> a while ago.
> https://lore.kernel.org/linux-iio/20250629194336.34a03946@jic23-huawei/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-26 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 17:21 [PATCH v1 0/3] iio: adc: bcm_iproc_adc: Convert to devm-managed resources mdshahid03
2026-08-25 17:21 ` [PATCH v1 1/3] iio: adc: bcm_iproc_adc: sort headers alphabetically mdshahid03
2026-08-26 3:28 ` Marcelo Schmitt
2026-08-26 8:26 ` Andy Shevchenko [this message]
2026-08-25 17:21 ` [PATCH v1 2/3] iio: adc: bcm_iproc_adc: use devm_add_action_or_reset() mdshahid03
2026-08-26 3:33 ` Marcelo Schmitt
2026-08-25 17:21 ` [PATCH v1 3/3] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization mdshahid03
2026-08-26 3:35 ` Marcelo Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao6jQaJc9FokuK6A@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=mdshahid03@gmail.com \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.