From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, dave@treblig.org,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 42/49] hw: guard BusClass::print_dev with CONFIG_HMP
Date: Wed, 26 Aug 2026 10:03:59 +0100 [thread overview]
Message-ID: <ao6r_y3LVtdhCnLj@redhat.com> (raw)
In-Reply-To: <20260825-qemu-no-hmp-v4-42-af60857c2fbe@redhat.com>
On Tue, Aug 25, 2026 at 11:09:49PM +0400, Marc-André Lureau wrote:
> The print_dev callback is only used by HMP 'info qtree'. Guard the field
> in BusClass, all implementations, and the caller with CONFIG_HMP.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/char/virtio-serial-bus.c | 6 ++++++
> hw/core/sysbus.c | 6 ++++++
> hw/misc/auxbus.c | 16 +++++++++++-----
> hw/pci/pci-hmp-cmds.c | 2 ++
> hw/pci/pci.c | 2 ++
> hw/usb/bus.c | 6 ++++++
> hw/xen/xen-bus.c | 4 ++++
> include/hw/core/qdev.h | 2 ++
> 8 files changed, 39 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-08-26 9:04 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 19:09 [PATCH v4 00/49] Make HMP optional (and later standalone) Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 01/49] build-sys: introduce CONFIG_HMP Marc-André Lureau
2026-08-26 8:38 ` Daniel P. Berrangé
2026-08-26 12:38 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 02/49] vl: fix -monitor none prefix matching Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 03/49] hmp: remove 'vcpu' argument from trace-event help Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 04/49] hmp: fix snapshot_blkdev argument type Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 05/49] target/i386: decouple cpu_x86_inject_mce() from Monitor Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 06/49] target/i386: return an error for invalid CPU in hmp_mce() Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 07/49] system: move gpa2hva() to system memory unit Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 08/49] monitor: move HMP-only fields from Monitor to MonitorHMP Marc-André Lureau
2026-08-26 8:40 ` Daniel P. Berrangé
2026-08-26 12:39 ` Philippe Mathieu-Daudé
2026-08-26 13:06 ` Marc-André Lureau
2026-08-26 17:48 ` Philippe Mathieu-Daudé
2026-08-26 19:15 ` Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 09/49] tests/functional: use query-version QMP command instead of HMP Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 10/49] net/qapi: add x-query-usernet command Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 11/49] python, tests: switch usernet queries from HMP to QMP Marc-André Lureau
2026-08-25 19:47 ` Thomas Huth
2026-08-25 19:09 ` [PATCH v4 12/49] tests/qtest/pnv: drop unnecessary -serial mon:stdio Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 13/49] tests/qtest/qmp-test: don't depend on human-monitor-command Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 14/49] tests/qtest/numa-test: replace HMP "info numa" with QMP query-cpus-fast Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 15/49] tests/qtest/cdrom-test: replace HMP "info block" with QMP query-block Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 16/49] tests/qtest/device-introspect-test: fix test without HMP Marc-André Lureau
2026-08-28 10:09 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 17/49] tests/qemu-iotests/205: fix race in assertExportNotFound Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 18/49] net: add x-query-network QMP command Marc-André Lureau
2026-08-28 10:12 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 19/49] tests/qtest/netdev-socket: replace HMP with x-query-network QMP Marc-André Lureau
2026-08-28 10:13 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 20/49] qemu-io: propagate errors through Error API instead of printf Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 21/49] block: add x-qemu-io QMP command Marc-André Lureau
2026-08-26 12:43 ` Philippe Mathieu-Daudé
2026-08-26 13:08 ` Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 22/49] qtest: add qemu-io command to the qtest protocol Marc-André Lureau
2026-08-26 12:48 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 23/49] qtest/ide-test: convert to use qtest qemu-io command Marc-André Lureau
2026-08-26 12:49 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 24/49] tests/qemu-iotests: add qmp_qemu_io() Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 25/49] tests/qemu-iotests: convert pause/resume_drive() to QMP Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 26/49] monitor: reject readline monitor when HMP is disabled Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 27/49] system: guard HMP initialization paths with CONFIG_HMP Marc-André Lureau
2026-08-26 17:56 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 28/49] tests: skip HMP-dependent tests when HMP is disabled Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 29/49] monitor: isolate HMP declarations in hmp.h Marc-André Lureau
2026-08-26 17:55 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 30/49] monitor: change HMPCommand cmd to take MonitorHMP Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 31/49] monitor: make hmp_handle_error() " Marc-André Lureau
2026-08-26 17:54 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 32/49] monitor: add monitor_cur_hmp() helper Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 33/49] qemu-print: document HMP/QMP behaviour better Marc-André Lureau
2026-08-26 8:45 ` Daniel P. Berrangé
2026-08-25 19:09 ` [PATCH v4 34/49] error-report: switch to use monitor_cur_hmp() Marc-André Lureau
2026-08-25 21:46 ` Philippe Mathieu-Daudé
2026-08-26 17:49 ` Philippe Mathieu-Daudé
2026-08-26 8:46 ` Daniel P. Berrangé
2026-08-25 19:09 ` [PATCH v4 35/49] monitor: tighten monitor_set_cpu()/get_cpu() Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 36/49] monitor: tighten monitor_printf*() Marc-André Lureau
2026-08-26 8:54 ` Daniel P. Berrangé
2026-08-26 9:41 ` Marc-André Lureau
2026-08-26 10:03 ` Daniel P. Berrangé
2026-08-26 13:04 ` Marc-André Lureau
2026-08-28 10:19 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 37/49] hexagon: make dump_mmu() take MonitorHMP Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 38/49] qdev-monitor: make print_dev() callback " Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 39/49] qapi: make HMP-specific schema entries conditional on CONFIG_HMP Marc-André Lureau
2026-08-26 9:02 ` Daniel P. Berrangé
2026-08-26 9:45 ` Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 40/49] Guard HMP command implementations with CONFIG_HMP Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 41/49] target: guard MonitorDef tables " Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 42/49] hw: guard BusClass::print_dev " Marc-André Lureau
2026-08-26 9:03 ` Daniel P. Berrangé [this message]
2026-08-25 19:09 ` [PATCH v4 43/49] hexagon: condition HMP-specific code Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 44/49] build-sys: make HMP source files conditional on have_hmp Marc-André Lureau
2026-08-26 17:43 ` Philippe Mathieu-Daudé
2026-08-26 19:09 ` Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 45/49] stubs: split monitor-core stubs into separate compilation units Marc-André Lureau
2026-08-25 21:44 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 46/49] monitor: move monitor_hmp_print*() functions to hmp.c Marc-André Lureau
2026-08-26 17:45 ` Philippe Mathieu-Daudé
2026-08-26 19:17 ` Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 47/49] monitor: move HMP-specific to monitor-hmp-internal.h Marc-André Lureau
2026-08-26 17:52 ` Philippe Mathieu-Daudé
2026-08-25 19:09 ` [PATCH v4 48/49] build-sys: add 'hmp' option Marc-André Lureau
2026-08-25 19:09 ` [PATCH v4 49/49] gitlab: --disable-hmp in build-without-defaults Marc-André Lureau
2026-08-25 21:43 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao6r_y3LVtdhCnLj@redhat.com \
--to=berrange@redhat.com \
--cc=amit@kernel.org \
--cc=anthony@xenproject.org \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=edgar.iglesias@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@mailo.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.