All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Nilay Shroff <nilay@linux.ibm.com>
Cc: wenxiong@linux.ibm.com, linux-nvme@lists.infradead.org,
	gjoyce@linux.ibm.com, wenxiong@us.ibm.com
Subject: Re: [PATCH V2] nvme: Add module reference counting for multipath devices
Date: Wed, 26 Aug 2026 08:23:42 -0600	[thread overview]
Message-ID: <ao727q88MeuHbU2F@kbusch-mbp> (raw)
In-Reply-To: <d3cb6438-f1b6-4b46-9f96-56819052bc02@linux.ibm.com>

On Wed, Aug 26, 2026 at 06:10:09PM +0530, Nilay Shroff wrote:
> when none of those namespaces are actually in use. So for instance,
> with this change now, I can't rmmod nvme.ko until I delete
> all namespaces/paths created under PCIe nvme subsystem, even though
> no one is using the namespace/path under that subsystem.

I'd call that a feature. :)

> Instead, I think the module reference should track the lifetime of an
> active user of the multipath namespace. When the namespace is in use,
> the corresponding transport module(s) need to remain loaded and once
> the namespace is no longer in use, those references should be released.

That's what v1 was trying to do, but it doesn't work. The transports
used to reach a namespace may not be the same across the open and close.


  reply	other threads:[~2026-08-26 14:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 22:32 [PATCH V2] nvme: Add module reference counting for multipath devices wenxiong
2026-08-20  4:19 ` Nares Bannoth
2026-08-23  0:20 ` Sagi Grimberg
2026-08-23  0:46   ` Sagi Grimberg
2026-08-24 20:23     ` Wen Xiong
2026-08-25 19:11     ` Wen Xiong
2026-08-30 21:46       ` Sagi Grimberg
2026-08-26 12:40 ` Nilay Shroff
2026-08-26 14:23   ` Keith Busch [this message]
2026-08-26 16:18   ` Wen Xiong
2026-08-26 16:36     ` Keith Busch
2026-08-27 13:21       ` Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao727q88MeuHbU2F@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=gjoyce@linux.ibm.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=wenxiong@linux.ibm.com \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.