All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
	 intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	 Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH v1 1/1] drm/i915/gem: Use simpler versions of min*()
Date: Wed, 26 Aug 2026 18:47:14 +0200	[thread overview]
Message-ID: <ao8YOAaBsWijMecG@zenone.zhora.eu> (raw)
In-Reply-To: <ao6lOyo5abFmwpN9@ashevche-desk.local>

Hi Andy,

> > > -		nr_pages = min_array(((unsigned long[]) {
> > > -					folio_nr_pages(folio),
> > > -					page_count - i,
> > > -					max_segment / PAGE_SIZE,
> > > -				      }), 3);
> > > +		nr_pages = min3(folio_nr_pages(folio),
> > > +				page_count - i, max_segment / PAGE_SIZE);
> > 
> > thanks for your patch, but there is another patch involving (and
> > fixing) this line of code[*]. You are welcome to join the review.
> 
> Thanks for pointing this out! Do you prefer my to be rebased on top?
> Otherwise one can apply this patch first.
> 
> > [*] https://patchwork.freedesktop.org/patch/746877/?series=172332&rev=1
> 
> Note, my patch doesn't change existing behaviour.

yeah... besides that patch has had some reviews to follow up;
Krzysztof will have a little conflict easy to fix.

I reviewed and pushed your branch to drm-intel-gt-next.

Thanks,
Andi

  reply	other threads:[~2026-08-26 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  9:35 [PATCH v1 1/1] drm/i915/gem: Use simpler versions of min*() Andy Shevchenko
2026-08-25  9:43 ` sashiko-bot
2026-08-25 10:28 ` ✓ i915.CI.BAT: success for series starting with [v1,1/1] " Patchwork
2026-08-25 13:44 ` [PATCH v1 1/1] " Andi Shyti
2026-08-26  8:35   ` Andy Shevchenko
2026-08-26 16:47     ` Andi Shyti [this message]
2026-08-25 15:09 ` ✗ i915.CI.Full: failure for series starting with [v1,1/1] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao8YOAaBsWijMecG@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.