From: Richard Patel <ripatel@wii.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Steve Douthit <stephend@silicom-usa.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ixgbe: fix MDIO bus leak when rejecting SFP module
Date: Wed, 26 Aug 2026 18:27:04 +0000 [thread overview]
Message-ID: <ao8v+E27nWRW7g7V@wii.dev> (raw)
In-Reply-To: <87e4aa92-4687-4fbf-b632-9493932c349f@lunn.ch>
On Wed, Aug 26, 2026 at 02:23:25PM +0200, Andrew Lunn wrote:
> On Wed, Aug 26, 2026 at 04:29:45AM +0000, Richard Patel wrote:
> > This code path failed to unregister an MDIO bus owned by that
> > netdev, so when unregister_netdev() tries to tear it down
> > (via device_del() -> devres_release_all() -> mdiobus_free()),
> > it trips over the leaked registration.
>
> Maybe look at using devm_mdiobus_register()?
oh nice. Will submit a V2 tomorrow with that instead, thanks.
Richard
prev parent reply other threads:[~2026-08-26 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 4:29 [PATCH] ixgbe: fix MDIO bus leak when rejecting SFP module Richard Patel
2026-08-26 12:23 ` Andrew Lunn
2026-08-26 18:27 ` Richard Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao8v+E27nWRW7g7V@wii.dev \
--to=ripatel@wii.dev \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=stephend@silicom-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.