From: Dan Carpenter <error27@gmail.com>
To: Ivy Lopez <skunkolee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8
Date: Mon, 17 Aug 2026 10:49:41 +0300 [thread overview]
Message-ID: <aoK9FSiIGeveeANA@stanley.mountain> (raw)
In-Reply-To: <20260815191030.24989-1-skunkolee@gmail.com>
On Sat, Aug 15, 2026 at 01:10:30PM -0600, Ivy Lopez wrote:
> EEPROM_DEFAULT_DIFF is defined as the bare integer literal 0xFE
> (254) but is only ever assigned into s8 (signed char) fields used
> to store signed TX power calibration offsets. The implicit
> truncation to -2 is intentional.
Just change it to:
#define EEPROM_DEFAULT_DIFF -2
regards,
dan carpenter
next prev parent reply other threads:[~2026-08-17 7:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 19:10 [PATCH] staging: rtl8723bs: cast EEPROM_DEFAULT_DIFF to s8 Ivy Lopez
2026-08-17 7:49 ` Dan Carpenter [this message]
2026-08-17 21:05 ` [PATCH v2] staging: rtl8723bs: define EEPROM_DEFAULT_DIFF as -2 directly Ivy Lopez
2026-09-01 10:03 ` Greg Kroah-Hartman
2026-09-02 1:48 ` [PATCH v3] " Ivy Lopez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoK9FSiIGeveeANA@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skunkolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.