All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx@kernel.org>
To: Bhavik Sachdev <b.sachdev1904@gmail.com>,
	 Josef Bacik <josef@toxicpanda.com>
Cc: linux-man@vger.kernel.org, Christian Brauner <brauner@kernel.org>,
	 Miklos Szeredi <mszeredi@redhat.com>,
	linux-fsdevel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] man/man2/statmount.2: Fix incorrect function signature
Date: Mon, 17 Aug 2026 11:07:38 +0200	[thread overview]
Message-ID: <aoLOb0tixHee3AkZ@debian> (raw)
In-Reply-To: <20260815074526.1094308-1-b.sachdev1904@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

Hi Bhavik, Josef,

> Date: 2026-08-15 13:15:26+0530
> From: Bhavik Sachdev <b.sachdev1904@gmail.com>
>
> flags argument is an unsigned int not an unsigned long [1].
> 
> [1]:
> <https://github.com/torvalds/linux/blob/master/fs/namespace.c#L5961>

Thanks!

> Fixes: c011cc992510 (2024-07-09; "statmount.2: Add page")

Please CC the people involved in that commit.  (I've done it now.)

> Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
> ---
>  man/man2/statmount.2 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man/man2/statmount.2 b/man/man2/statmount.2
> index b6d9dc2a1..a365002dd 100644
> --- a/man/man2/statmount.2
> +++ b/man/man2/statmount.2
> @@ -16,7 +16,7 @@ Standard C library
>  .P
>  .BI "int syscall(SYS_statmount, struct mnt_id_req *" req ,
>  .BI "            struct statmount *" smbuf ", size_t " bufsize ,
> -.BI "            unsigned long " flags );
> +.BI "            unsigned int " flags );

LGTM.

$ grepc -tfld statmount . | head -n4
./fs/namespace.c:SYSCALL_DEFINE4(statmount, const struct mnt_id_req __user *, req,
		struct statmount __user *, buf, size_t, bufsize,
		unsigned int, flags)
{


Josef, was it just a typo, or is there anything that needs checking?


Have a lovely day!
Alex

>  .P
>  .B #include <linux/mount.h>
>  .fi
> -- 
> 2.53.0
> 
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2026-08-17  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15  7:45 [PATCH] man/man2/statmount.2: Fix incorrect function signature Bhavik Sachdev
2026-08-17  9:07 ` Alejandro Colomar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoLOb0tixHee3AkZ@debian \
    --to=alx@kernel.org \
    --cc=b.sachdev1904@gmail.com \
    --cc=brauner@kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.