Re: [PATCH v2 1/3] selftests/mm: emit TAP header in uffd-wp-mremap

["Lorenzo Stoakes (ARM)" <ljs@kernel.org>]

On Sat, Aug 15, 2026 at 04:07:14PM +0800, Song Hu wrote:
> uffd-wp-mremap calls ksft_set_plan() without ksft_print_header(), so its
> output is not valid KTAP.  Add the header, like the sibling uffd tests
> (uffd-stress, uffd-unit-tests).
>
> Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> Reviewed-by: Sarthak Sharma <sarthak.sharma@arm.com>
> Signed-off-by: Song Hu <husong@kylinos.cn>

This all seems to be yet another way of saying 'somebody didn't use the
kselftest harness and so things went wrong' :)

Acked-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

> ---
>  tools/testing/selftests/mm/uffd-wp-mremap.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/uffd-wp-mremap.c b/tools/testing/selftests/mm/uffd-wp-mremap.c
> index c973d6722720..572c2516e874 100644
> --- a/tools/testing/selftests/mm/uffd-wp-mremap.c
> +++ b/tools/testing/selftests/mm/uffd-wp-mremap.c
> @@ -347,6 +347,8 @@ int main(int argc, char **argv)
>  	struct thp_settings settings;
>  	int i, j, plan = 0;
>
> +	ksft_print_header();
> +
>  	hugepage_save_settings(true, true);
>
>  	check_uffd_wp_feature_supported();
> --
> 2.43.0
>

--
Cheers, Lorenzo