All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: ZhilingZouzhilinz@nebusec.ai
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
	phil@nwl.cc, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, horms@kernel.org, bazsi@balabit.hu,
	kaber@trash.net, hidden@balabit.hu, vega@nebusec.ai,
	zhilinz@nebusec.ai
Subject: Re: [PATCH nf 1/1] netfilter: xt_TPROXY: require IPv6 protocol match
Date: Mon, 17 Aug 2026 17:57:33 +0200	[thread overview]
Message-ID: <aoMvba90k7F4nCp0@strlen.de> (raw)
In-Reply-To: <6ca536c61d358bfb1bdfd20aafe3cc16acfd45db.1786968834.git.zhilinz@nebusec.ai>

ZhilingZouzhilinz@nebusec.ai <ZhilingZouzhilinz@nebusec.ai> wrote:
> From: Zhiling Zou <zhilinz@nebusec.ai>
> 
> tproxy_tg6_check() verifies the protocol field value but does not
> require IP6T_F_PROTO. A crafted ip6tables rule can set the field to
> TCP or UDP while leaving the protocol matching flag clear.
> 
> ip6_packet_match() treats such a rule as protocol agnostic and can
> invoke tproxy_tg6_v1() for ICMPv6. nf_tproxy_get_sock_v6() warns for
> protocols other than TCP and UDP.
> 
> Reject rules without IP6T_F_PROTO so TPROXY is invoked only for the
> protocols it supports.

Reviewed-by: Florian Westphal <fw@strlen.de>

Looks like l2tp_mt_check6() has same problem.
Would you mind sending a second patch for xt_l2tp.c ?  Else I can
do it.

  reply	other threads:[~2026-08-17 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 12:26 [PATCH nf 0/1] netfilter: xt_TPROXY: require IPv6 protocol match Zhiling
2026-08-17 12:26 ` [PATCH nf 1/1] " Zhiling
2026-08-17 15:57   ` Florian Westphal [this message]
2026-08-17 16:08   ` Pablo Neira Ayuso
2026-08-17 16:11     ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoMvba90k7F4nCp0@strlen.de \
    --to=fw@strlen.de \
    --cc=ZhilingZouzhilinz@nebusec.ai \
    --cc=bazsi@balabit.hu \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hidden@balabit.hu \
    --cc=horms@kernel.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.