From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Linmao Li <lilinmao@kylinos.cn>,
Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>,
Jai Luthra <jai.luthra+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] media: rppx1: handle the MAIN_POST white balance gains block
Date: Mon, 17 Aug 2026 18:00:13 +0200 [thread overview]
Message-ID: <aoMveqnDXyPvJdTD@zed> (raw)
In-Reply-To: <20260817154952.GI2757863@ragnatech.se>
Hello Linmao, Niklas
On Mon, Aug 17, 2026 at 05:49:52PM +0200, Niklas Söderlund wrote:
> Hi Linmao,
>
> Thanks for your work.
>
> On 2026-08-17 18:45:28 +0800, Linmao Li wrote:
> > RPPX1_PARAMS_BLOCK_TYPE_AWBG_POST is defined in the uAPI, the MAIN_POST
> > white balance gains module is probed and started, and
> > RPPX1_PARAMS_MAX_SIZE already reserves room for all three white balance
> > gains blocks. However, the parameters type table has no entry for
> > AWBG_POST and rppx1_params() does not dispatch it, so userspace cannot
> > configure the module.
> >
> > The missing type-table entry is zero-initialised. A zero-sized
> > AWBG_POST block can therefore make v4l2_isp_params_validate_buffer()
> > loop forever. A pending v4l2-isp patch rejects zero-sized blocks in the
> > common validator.
> >
> > Add the missing type entry and dispatch AWBG_POST to rpp->post.awbg.
> >
> > Fixes: 9ebf50010c68 ("media: rppx1: awbg: Add support for white balance gain settings")
> > Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
> > ---
> > drivers/media/platform/dreamchip/rppx1/rpp_params.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/media/platform/dreamchip/rppx1/rpp_params.c b/drivers/media/platform/dreamchip/rppx1/rpp_params.c
> > index a75a27a8afd09..88162f0bdc115 100644
> > --- a/drivers/media/platform/dreamchip/rppx1/rpp_params.c
> > +++ b/drivers/media/platform/dreamchip/rppx1/rpp_params.c
> > @@ -25,6 +25,7 @@ rppx1_ext_params_blocks_info[] = {
> > RPPX1_PARAMS_BLOCK_INFO(LSC_PRE2, lsc),
> > RPPX1_PARAMS_BLOCK_INFO(AWBG_PRE1, awbg),
> > RPPX1_PARAMS_BLOCK_INFO(AWBG_PRE2, awbg),
> > + RPPX1_PARAMS_BLOCK_INFO(AWBG_POST, awbg),
>
> This looks good.
>
> > RPPX1_PARAMS_BLOCK_INFO(CCOR_POST, ccor),
> > RPPX1_PARAMS_BLOCK_INFO(HIST_PRE1, hist),
> > RPPX1_PARAMS_BLOCK_INFO(HIST_PRE2, hist),
> > @@ -79,6 +80,9 @@ int rppx1_params(struct rppx1 *rpp, struct vb2_buffer *vb, size_t max_size,
> > case RPPX1_PARAMS_BLOCK_TYPE_AWBG_PRE1:
> > module = &rpp->pre1.awbg;
> > break;
> > + case RPPX1_PARAMS_BLOCK_TYPE_AWBG_POST:
> > + module = &rpp->post.awbg;
> > + break;
>
> As you point out in the cover letter there are many modules, specially
> in the PRE2 pipeline, that we reserve space for in the configuration
> buffer but to not dispatch yet. But also some in the POST pipeline. The
> reason for this is that we have no users (libcamera) or test-cases for
> those blocks.
>
> I think I would prefers keeping it like this until we do. If you really
> really want to go this path should you not also add AWBG_PRE2 here, that
> is also not dispatched ;-) But I think you should drop this and just add
> the missing entry to rppx1_ext_params_blocks_info.
FYI: https://patchwork.linuxtv.org/project/linux-media/patch/20260815193839.141406-1-devnexen@gmail.com/
I feel like we should populate all blocks indeed to avoid holes in the
rppx1_ext_params_blocks_info[] array.
If we can work out a patch quick enough we can send it as a fix and
have it collected with the rpp-x1 driver for v7.3 (hence, no need for
a fixes tag).
Thanks
j
>
> > case RPPX1_PARAMS_BLOCK_TYPE_CCOR_POST:
> > module = &rpp->post.ccor;
> > break;
> > --
> > 2.25.1
> >
>
> --
> Kind Regards,
> Niklas Söderlund
>
next prev parent reply other threads:[~2026-08-17 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 10:45 [PATCH 0/2] media: rppx1: parameters block fixes Linmao Li
2026-08-17 10:45 ` [PATCH 1/2] media: rppx1: handle the MAIN_POST white balance gains block Linmao Li
2026-08-17 15:49 ` Niklas Söderlund
2026-08-17 16:00 ` Jacopo Mondi [this message]
2026-08-17 10:45 ` [PATCH 2/2] media: rppx1: bls: read the raw pattern from the PRE2 acquisition module Linmao Li
2026-08-17 17:14 ` Niklas Söderlund
2026-08-18 6:25 ` Jacopo Mondi
2026-08-18 8:20 ` Niklas Söderlund
2026-08-18 8:41 ` Jacopo Mondi
2026-08-18 8:46 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoMveqnDXyPvJdTD@zed \
--to=jacopo.mondi@ideasonboard.com \
--cc=jacopo.mondi+renesas@ideasonboard.com \
--cc=jai.luthra+renesas@ideasonboard.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.