From: Peter Xu <peterx@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: jasowang@redhat.com, mst@redhat.com, armbru@redhat.com,
farosas@suse.de, raphael.s.norwitz@gmail.com, bchaney@akamai.com,
qemu-devel@nongnu.org, berrange@redhat.com, pbonzini@redhat.com,
yc-core@yandex-team.ru, mark.caveayland@nutanix.com
Subject: Re: [PATCH v20 10/15] migration/channel: check that transfer is UNIX socket when "local" set
Date: Mon, 17 Aug 2026 14:49:43 -0400 [thread overview]
Message-ID: <aoNXx0cjLgIP7RBg@x1.local> (raw)
In-Reply-To: <b9957dda-c0ee-4081-8938-ecc5a50aae3c@yandex-team.ru>
On Mon, Aug 17, 2026 at 09:15:17PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > We only need to touch migration_capabilities_and_transport_compatible()?
> > It should work for both, and fail QMP commands directly might also be
> > slightly better.
>
>
> Hm. Actually, migration_capabilities_and_transport_compatible() only sees
> the parsed MigrationAddress, before any QIOChannel is created. At that
> point we can't call qio_channel_has_feature(ioc, QIO_CHANNEL_FEATURE_FD_PASS),
> because there is no ioc yet..
>
> So, at least, we can't check, is passed from user fd is a UNIX socket
> for SOCKET_ADDRESS_TYPE_FD case.
Maybe have one extra step for FD with socket_sockaddr_to_address()?
--
Peter Xu
next prev parent reply other threads:[~2026-08-17 18:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 9:12 [PATCH v20 00/15] virtio-net: live-TAP local migration Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 01/15] net/tap: rework tap_parse_script Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 02/15] net/tap: improve script/downscript options documentation Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 03/15] net/tap: deprecate "no" as special value for script/downscript Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 04/15] net/tap: move vhost-net open() calls to tap_parse_vhost_fds() Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 05/15] net/tap: move vhost initialization to tap_setup_vhost() Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 06/15] net/tap: use container_of instead of DO_UPCAST Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 07/15] net/tap: QOMify tap backend Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 08/15] net/tap: add TYPE_VMSTATE_IF interface Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 09/15] qapi: add local migration parameter Vladimir Sementsov-Ogievskiy
2026-07-29 11:10 ` Markus Armbruster
2026-07-29 14:05 ` Peter Xu
2026-07-29 9:12 ` [PATCH v20 10/15] migration/channel: check that transfer is UNIX socket when "local" set Vladimir Sementsov-Ogievskiy
2026-07-29 14:09 ` Peter Xu
2026-07-29 17:53 ` Vladimir Sementsov-Ogievskiy
2026-08-17 18:15 ` Vladimir Sementsov-Ogievskiy
2026-08-17 18:49 ` Peter Xu [this message]
2026-07-29 9:12 ` [PATCH v20 11/15] virtio-net: support local migration of backend Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 12/15] net/tap: disable read polling for stopped VM Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 13/15] net/tap: support local migration with virtio-net Vladimir Sementsov-Ogievskiy
2026-07-29 11:30 ` Markus Armbruster
2026-07-29 12:25 ` Vladimir Sementsov-Ogievskiy
2026-07-29 12:45 ` Markus Armbruster
2026-07-29 9:12 ` [PATCH v20 14/15] tests/functional: add skipWithoutSudo() decorator Vladimir Sementsov-Ogievskiy
2026-07-29 9:12 ` [PATCH v20 15/15] tests/functional: add test_tap_migration Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoNXx0cjLgIP7RBg@x1.local \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=bchaney@akamai.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=mark.caveayland@nutanix.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=raphael.s.norwitz@gmail.com \
--cc=vsementsov@yandex-team.ru \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.