From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
Cc: kernel@oss.qualcomm.com, avaneesh.dwivedi@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/4] power: reset: add PSCRR NVMEM recorder
Date: Tue, 18 Aug 2026 11:02:46 +0200 [thread overview]
Message-ID: <aoQe4dvuUtHOZ0jg@monoceros> (raw)
In-Reply-To: <20260817-pscrr-provider-v1-2-88a318c13d41@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
Hello,
On Mon, Aug 17, 2026 at 06:59:42PM +0530, Faruque Ansari wrote:
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/nvmem-consumer.h>
> +#include <linux/platform_device.h>
> +#include <linux/pscrr.h>
> +#include <linux/reboot.h>
> +#include <linux/slab.h>
Please rely on <linux/platform_device.h> to provide of_device_id and
drop <linux/mod_devicetable.h>. The latter header will go away soon (and
<linux/platform_device.h> only includes <linux/device-id/platform.h>
which introduces much less dependencies.)
> [...]
> +static const struct of_device_id pscrr_nvmem_of_match[] = {
> + { .compatible = "pscrr-nvmem" },
> + {}
{ } please (i.e. add a space)
> +};
> +MODULE_DEVICE_TABLE(of, pscrr_nvmem_of_match);
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-18 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 13:29 [PATCH 0/4] power: reset: add NVMEM recorder provider for PSCRR Faruque Ansari
2026-08-17 13:29 ` [PATCH 1/4] dt-bindings: power: reset: add PSCRR NVMEM recorder binding Faruque Ansari
2026-08-18 6:47 ` Krzysztof Kozlowski
2026-08-18 10:29 ` Faruque Ansari
2026-08-17 13:29 ` [PATCH 2/4] power: reset: add PSCRR NVMEM recorder Faruque Ansari
2026-08-18 9:02 ` Uwe Kleine-König [this message]
2026-08-17 13:29 ` [PATCH 3/4] nvmem: provide consumer access to cell size metrics Faruque Ansari
2026-08-17 13:29 ` [PATCH 4/4] arm64: dts: qcom: lemans: add PSCRR NVMEM recorder node Faruque Ansari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoQe4dvuUtHOZ0jg@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=avaneesh.dwivedi@oss.qualcomm.com \
--cc=faruque.ansari@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.