All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangbin Liu <hangbin.liu@linux.dev>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
	Jay Vosburgh <jv@jvosburgh.net>, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>, Jiale Yao <yaojiale02@163.com>
Subject: Re: [PATCH net] net: do not bond/team netdevices which use ml_priv
Date: Tue, 18 Aug 2026 18:12:26 +0800	[thread overview]
Message-ID: <aoQwCj9AXNI1qfsu@fedora> (raw)
In-Reply-To: <02333bd9-89c4-4952-8ae2-ff3c15dcd4df@hartkopp.net>

On Sat, Aug 15, 2026 at 07:23:35PM +0200, Oliver Hartkopp wrote:
> 
> 
> On 15.08.26 18:00, Stephen Hemminger wrote:
> > On Sat, 15 Aug 2026 17:39:38 +0200
> > Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> > 
> > > +static inline bool netdev_has_ml_priv(struct net_device *dev)
> > > +{
> > > +	return (dev->ml_priv != NULL);
> > > +}
> > > +
> > 
> > Minor suggestion: use const and drop unneeded parens
> > 
> > static inline bool netdev_has_ml_priv(const struct net_device *dev)
> > {
> > 	return dev->ml_priv != NULL;
> > }
> > 
> > 
> 
> Good point!
> 
> Will wait for some more feedback before sending a v2.

Hi Oliver,

Sashiko gives some feed back[1], would you please check it?

[1] https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260815153938.187073-1-socketcan%40hartkopp.net

Thanks
Hangbin

  reply	other threads:[~2026-08-18 10:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 15:39 [PATCH net] net: do not bond/team netdevices which use ml_priv Oliver Hartkopp
2026-08-15 16:00 ` Stephen Hemminger
2026-08-15 17:23   ` Oliver Hartkopp
2026-08-18 10:12     ` Hangbin Liu [this message]
2026-08-18 13:25       ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoQwCj9AXNI1qfsu@fedora \
    --to=hangbin.liu@linux.dev \
    --cc=jiri@resnulli.us \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=socketcan@hartkopp.net \
    --cc=stephen@networkplumber.org \
    --cc=yaojiale02@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.