From: Florian Westphal <fw@strlen.de>
To: Ren Wei <weir@nebusec.ai>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org,
phil@nwl.cc, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
luciano.coelho@nokia.com, kaber@trash.net,
quic_manojbm@quicinc.com, quic_subashab@quicinc.com,
vega@nebusec.ai, rakukuip@gmail.com
Subject: Re: [PATCH nf 1/1] netfilter: xt_IDLETIMER: validate label before debug logging in checkentry
Date: Tue, 18 Aug 2026 12:14:14 +0200 [thread overview]
Message-ID: <aoQwbtJ9vHfFb8Fx@strlen.de> (raw)
In-Reply-To: <b139065e9f62868ac5ed0900faf1dcd13c7e68f8.1786933680.git.rakukuip@gmail.com>
Ren Wei <weir@nebusec.ai> wrote:
> Fix this by moving the pr_debug() calls after idletimer_tg_helper() has
> successfully validated the label string.
I think it would be better to just zap this pr_debug, I don't think it
provides any benefit to have it.
next prev parent reply other threads:[~2026-08-18 10:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 1:56 [PATCH nf 0/1] netfilter: xt_IDLETIMER: fix out-of-bounds heap read in checkentry Ren Wei
2026-08-18 1:56 ` [PATCH nf 1/1] netfilter: xt_IDLETIMER: validate label before debug logging " Ren Wei
2026-08-18 8:05 ` Fernando Fernandez Mancera
2026-08-18 10:14 ` Florian Westphal [this message]
2026-08-18 8:04 ` [PATCH nf 0/1] netfilter: xt_IDLETIMER: fix out-of-bounds heap read " Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoQwbtJ9vHfFb8Fx@strlen.de \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kaber@trash.net \
--cc=kuba@kernel.org \
--cc=luciano.coelho@nokia.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=quic_manojbm@quicinc.com \
--cc=quic_subashab@quicinc.com \
--cc=rakukuip@gmail.com \
--cc=vega@nebusec.ai \
--cc=weir@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.