All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: sashiko-reviews@lists.linux.dev
Cc: Prabhakar <prabhakar.csengg@gmail.com>,
	linux-rtc@vger.kernel.org, robh@kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 12/12] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs
Date: Tue, 18 Aug 2026 13:28:48 +0200	[thread overview]
Message-ID: <aoRB8CrV7ECOG33Y@ninjato> (raw)
In-Reply-To: <20260706180331.3AD811F000E9@smtp.kernel.org>

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]


> Should we add match data to this compatible string to identify the variant
> and explicitly reject probe with -EOPNOTSUPP if the clock configuration
> would require the unsupported SUBU mode?

Correct. Matches also my notes which say that this code

445                 if (rate != 32768)
446                         scmp_val = RZN1_RTC_CTL0_SLSB_SCMP;

is wrong when we have a variant which has no SUBU support. Because in
that case, we need to enable SCMP even for 32768Hz.

So, yes, it is needed to mark which variant has SUBU (RZ/N1 only, likely
forever) and bail out if no SUBU and no 'xtal'. The above code needs to
check SUBU support, too.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-08-18 11:28 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 17:51 [PATCH v3 00/12] Add RTC support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-07-06 17:51 ` [PATCH v3 01/12] dt-bindings: rtc: renesas,rzn1-rtc: Add RZ/T2H and RZ/N2H support Prabhakar
2026-07-06 17:58   ` sashiko-bot
2026-08-18  7:42     ` Wolfram Sang
2026-08-18 14:32       ` Lad, Prabhakar
2026-07-06 17:51 ` [PATCH v3 02/12] rtc: rzn1: Handle EPROBE_DEFER for optional pps interrupt Prabhakar
2026-07-06 17:56   ` sashiko-bot
2026-08-18  7:43   ` Wolfram Sang
2026-07-06 17:51 ` [PATCH v3 03/12] rtc: rzn1: fix weekday underflow when alarm crosses month boundary Prabhakar
2026-07-06 18:00   ` sashiko-bot
2026-08-18 10:10   ` Wolfram Sang
2026-08-18 14:35     ` Lad, Prabhakar
2026-07-06 17:51 ` [PATCH v3 04/12] rtc: rzn1: Fix malformed MODULE_AUTHOR string Prabhakar
2026-07-06 17:53   ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 05/12] rtc: Kconfig: Broaden RTC_DRV_RZN1 dependency to ARCH_RENESAS Prabhakar
2026-07-06 17:54   ` sashiko-bot
2026-08-18 10:11   ` Wolfram Sang
2026-07-06 17:51 ` [PATCH v3 06/12] rtc: rzn1: Fix alarm range check truncation on 32-bit systems Prabhakar
2026-07-06 18:04   ` sashiko-bot
2026-08-18 10:32   ` Wolfram Sang
2026-07-06 17:51 ` [PATCH v3 07/12] rtc: rzn1: Replace remove callback with devm_add_action_or_reset() Prabhakar
2026-07-06 17:58   ` sashiko-bot
2026-08-18 10:37   ` Wolfram Sang
2026-07-06 17:51 ` [PATCH v3 08/12] rtc: rzn1: Dynamically calculate synchronization delay based on clock rate Prabhakar
2026-07-06 17:58   ` sashiko-bot
2026-08-18 10:49   ` Wolfram Sang
2026-08-18 14:37     ` Lad, Prabhakar
2026-07-06 17:51 ` [PATCH v3 09/12] rtc: rzn1: Use temporary variable for struct device Prabhakar
2026-07-06 17:56   ` sashiko-bot
2026-08-18 10:51     ` Wolfram Sang
2026-08-18 14:58       ` Lad, Prabhakar
2026-07-06 17:51 ` [PATCH v3 10/12] rtc: rzn1: Consistently use dev_err_probe() Prabhakar
2026-07-06 17:55   ` sashiko-bot
2026-07-06 17:51 ` [PATCH v3 11/12] rtc: rzn1: use FIELD_PREP/FIELD_GET and GENMASK for register access Prabhakar
2026-07-06 17:57   ` sashiko-bot
2026-08-18 11:19   ` Wolfram Sang
2026-07-06 17:51 ` [PATCH v3 12/12] rtc: rzn1: Add support for Renesas RZ/T2H and RZ/N2H SoCs Prabhakar
2026-07-06 18:03   ` sashiko-bot
2026-08-18 11:28     ` Wolfram Sang [this message]
2026-08-18 19:25       ` Lad, Prabhakar
2026-08-03 12:47 ` [PATCH v3 00/12] Add RTC " Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoRB8CrV7ECOG33Y@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.