From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30641C5DF7D for ; Tue, 18 Aug 2026 14:21:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwKgv-0007EH-VQ; Tue, 18 Aug 2026 10:21:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwKgt-0007DC-Aj for qemu-arm@nongnu.org; Tue, 18 Aug 2026 10:21:23 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwKgr-0000FU-GK for qemu-arm@nongnu.org; Tue, 18 Aug 2026 10:21:23 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-49557167508so47847915e9.1 for ; Tue, 18 Aug 2026 07:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787062880; x=1787667680; darn=nongnu.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iW1x2T4ow/KALArrlvmWQ5RLnDxMISOdqKzDbu4KUE4=; b=HHaqFC5Flv0sE/VYrqbwEyUB+bKZxb13QbWBoAmTRmiSSPYHTfzo72f7vELY0hGmY0 fZXR+gLuGrF0A4G77c88t/uTcpAx5lwwRh//clIsYSDrwOUkismYbAxVd5WnfJLNH2SJ z0N9gWYDv1AuVQZ8tqQZVY4Mo8lLhExFfJRnx/iTOMt9GXcCGEBO5iXwRrWGGoMAZe8z HGtSTnjdihIWWQD6fSveMYV803aycIKhTBr65CYpIuPdkQvLuBOlZd94nK+l2ArdkzaX aBSdtgpMkWcAAENUAuPxV1yYwN/Q9yTyHsrBLpfer1+W2gkBs1lvMEmkJbhyBmYg4zYq Asuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787062880; x=1787667680; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iW1x2T4ow/KALArrlvmWQ5RLnDxMISOdqKzDbu4KUE4=; b=sKx9t7fqurj0vEViTzRS2ZLZGqmVVAQ8bHckJpEe5HNgDpKFCZdD1J1zQxaoV+Lgbi DkOk3NJwtiJLCBcZf9aac4KiOXkIQr/c9s/rATFu0lwjfqqiaDC6snvCsUMZJyAH4xWo x17MubbG7I7dMt6oLyOM53p7Iw4zLLGpG8DgES76uKnONhdba4F7s6aKj/o5qq03gsY+ eBNCt6rPZ/JekdA5M2iCV5qgDJ/jstGY0NN1Q9lH6XshdhMUbCsE0bJ4ABB3AY1j9b+u +nJeVQICq6gge24rTseghhWoxbNA/9KZlTSxHh6VWn3Xswfs9x3j4EY/vrt1yAJo5MEl vyJg== X-Forwarded-Encrypted: i=1; AHgh+RpBg/5LY676G9ftgJ7ERtRRzwHgwvOUF3pTaGIgupVCAbFfEDT10pFYgCqi5/Y3B6P0L7YXwYocDg==@nongnu.org X-Gm-Message-State: AOJu0YwdDA8Coafb/ierWV+57m1/tV4fhFgURRVKqRauXQQ29XvMC70Y 1h98i3su4gcDPsUQXC407VB1yE/Piu25TSW4xCWTiqOzPRsVEE1t4BKKVct5Hz33mSk= X-Gm-Gg: AR+sD10JxV8pBPMCQpKRZAqlcblubuxDgD37+NYda/TvGw/n6hIKTFpBPxtZw4tQRKx a7RwZFSHAQZ5mwD8FFSGLqhnsNhQ7qmp6dPCX3bFOIJAHRdt5FWiJ1v5McZWRAgLw+ubPBSWbzV ig2c4zRDyqOCz1uj01oL+6TQDHdU/OKtMDgn93My6VpMlskwKDWJbu5jAu/pZPLPfMvgDijBjrj PcdRWgrQmiLo0byCd9v7s7oRKc+HOpy+/pvnnncpua4Njk+oN6EBrL0uuxi1EnY4JpX+/zBh3Nf Vra+FOIKsNUVTL8HM6mZyrbdcenVxj9qNyeQp+jTtrkh1LzAQicki5qETb+lA707kbmykD4hFLk HxDMenlPq1W39GaAqqnxKUlqNOsk6Eeqea2lYqa+g44F6L5V7plAXJQIvfA4r8p0Dw3wxgnkycg k0U9d5u+OJorp3NQa/6LLIz3qO1l8RFTuQ7ktM0m3v6kNxdY84jKMzFdVAmyknXA== X-Received: by 2002:a05:600c:848e:b0:499:8156:cd3f with SMTP id 5b1f17b1804b1-4999fb3f78bmr159851135e9.8.1787062879454; Tue, 18 Aug 2026 07:21:19 -0700 (PDT) Received: from linaro.org ([2a10:d582:31e:0:c289:2687:e46c:f7e3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961098cdsm284909685e9.6.2026.08.18.07.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 07:21:18 -0700 (PDT) Date: Tue, 18 Aug 2026 15:21:17 +0100 From: Jim MacArthur To: Tao Tang Cc: Eric Auger , Peter Maydell , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Chen Baozi , Pierrick Bouvier , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Mostafa Saleh , Chao Liu Subject: Re: [RFC v5 01/28] hw/arm/smmuv3: Introduce secure registers Message-ID: References: <20260813161515.2788900-1-tangtao1634@phytium.com.cn> <20260813162410.2805113-1-tangtao1634@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813162410.2805113-1-tangtao1634@phytium.com.cn> Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=jim.macarthur@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Fri, Aug 14, 2026 at 12:24:06AM +0800, Tao Tang wrote: > The Arm SMMUv3 architecture defines a set of registers for managing > Secure transactions and contexts. > > This patch introduces the definitions for these secure registers within > the SMMUv3 device model internal header. > > Signed-off-by: Tao Tang > Reviewed-by: Eric Auger > Reviewed-by: Pierrick Bouvier > Reviewed-by: Mostafa Saleh > Link: https://lore.kernel.org/qemu-devel/759ec110-365f-488b-802d-c7bb1efe30bc@redhat.com/ > --- > include/hw/arm/smmuv3-common.h | 71 +++++++++++++++++++++++++++++++++- > 1 file changed, 70 insertions(+), 1 deletion(-) > > diff --git a/include/hw/arm/smmuv3-common.h b/include/hw/arm/smmuv3-common.h > index 4609975edf9..ec442a85586 100644 > --- a/include/hw/arm/smmuv3-common.h > +++ b/include/hw/arm/smmuv3-common.h > @@ -269,7 +269,7 @@ REG32(CD_5, 20) > ((sel) ? ((cd)->word[4] = FIELD_DP32((cd)->word[4], CD_4, NSCFG1, (v))) : \ > ((cd)->word[2] = FIELD_DP32((cd)->word[2], CD_2, NSCFG0, (v)))) > > -/* MMIO Registers */ > +/* MMIO Registers. Shared by Non-secure/Realm/Root states. */ > > REG32(IDR0, 0x0) > FIELD(IDR0, S2P, 0 , 1) > @@ -353,6 +353,7 @@ REG32(CR0, 0x20) > FIELD(CR0, CMDQEN, 3, 1) > > #define SMMU_CR0_RESERVED 0xFFFFFA20 > +#define SMMU_S_CR0_RESERVED 0xFFFFFC12 > > REG32(CR0ACK, 0x24) > REG32(CR1, 0x28) > @@ -411,6 +412,74 @@ REG32(EVENTQ_IRQ_CFG2, 0xbc) > > #define A_IDREGS 0xfd0 > > +#define SMMU_SECURE_REG_START 0x8000 /* Start of secure-only registers */ > + > +REG32(S_IDR0, 0x8000) > + FIELD(S_IDR0, MSI, 13, 1) > + FIELD(S_IDR0, STALL_MODEL, 24, 2) > +REG32(S_IDR1, 0x8004) > + FIELD(S_IDR1, S_SIDSIZE, 0 , 6) > + FIELD(S_IDR1, SEL2, 29, 1) > + FIELD(S_IDR1, SECURE_IMPL, 31, 1) > + > +REG32(S_IDR2, 0x8008) > +REG32(S_IDR3, 0x800c) > +REG32(S_IDR4, 0x8010) > + > +REG32(S_CR0, 0x8020) > + FIELD(S_CR0, SMMUEN, 0, 1) > + FIELD(S_CR0, EVENTQEN, 2, 1) > + FIELD(S_CR0, CMDQEN, 3, 1) > + > +REG32(S_CR0ACK, 0x8024) > +REG32(S_CR1, 0x8028) > +REG32(S_CR2, 0x802c) > + > +REG32(S_INIT, 0x803c) > + FIELD(S_INIT, INV_ALL, 0, 1) > + > +REG32(S_GBPA, 0x8044) > + FIELD(S_GBPA, ABORT, 20, 1) > + FIELD(S_GBPA, UPDATE, 31, 1) > + > +REG32(S_IRQ_CTRL, 0x8050) > + FIELD(S_IRQ_CTRL, GERROR_IRQEN, 0, 1) > + FIELD(S_IRQ_CTRL, EVENTQ_IRQEN, 2, 1) > + > +REG32(S_IRQ_CTRLACK, 0x8054) > + > +REG32(S_GERROR, 0x8060) > + FIELD(S_GERROR, CMDQ_ERR, 0, 1) > + > +#define SMMU_GERROR_IRQ_CFG0_RESERVED 0x00FFFFFFFFFFFFFC > +#define SMMU_GERROR_IRQ_CFG2_RESERVED 0x000000000000003F > + > +#define SMMU_STRTAB_BASE_RESERVED 0x40FFFFFFFFFFFFC0 > +#define SMMU_QUEUE_BASE_RESERVED 0x40FFFFFFFFFFFFFF > +#define SMMU_EVENTQ_IRQ_CFG0_RESERVED 0x00FFFFFFFFFFFFFC > + > +REG32(S_GERRORN, 0x8064) > +REG64(S_GERROR_IRQ_CFG0, 0x8068) > +REG32(S_GERROR_IRQ_CFG1, 0x8070) > +REG32(S_GERROR_IRQ_CFG2, 0x8074) > +REG64(S_STRTAB_BASE, 0x8080) > +REG32(S_STRTAB_BASE_CFG, 0x8088) > + FIELD(S_STRTAB_BASE_CFG, LOG2SIZE, 0, 6) > + FIELD(S_STRTAB_BASE_CFG, SPLIT, 6, 5) > + FIELD(S_STRTAB_BASE_CFG, FMT, 16, 2) > + > +REG64(S_CMDQ_BASE, 0x8090) > +REG32(S_CMDQ_PROD, 0x8098) > +REG32(S_CMDQ_CONS, 0x809c) > + FIELD(S_CMDQ_CONS, ERR, 24, 7) > + > +REG64(S_EVENTQ_BASE, 0x80a0) > +REG32(S_EVENTQ_PROD, 0x80a8) > +REG32(S_EVENTQ_CONS, 0x80ac) > +REG64(S_EVENTQ_IRQ_CFG0, 0x80b0) > +REG32(S_EVENTQ_IRQ_CFG1, 0x80b8) > +REG32(S_EVENTQ_IRQ_CFG2, 0x80bc) > + > /* Commands */ > > typedef enum SMMUCommandType { > -- > 2.34.1 Reviewed-by: Jim MacArthur