All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	namhyung@kernel.org, acme@kernel.org,
	linux-perf-users@vger.kernel.org, Andi Kleen <ak@kernel.org>
Subject: Re: [PATCH v1] perf top: Merge hybrid common events
Date: Tue, 18 Aug 2026 10:29:52 -0700	[thread overview]
Message-ID: <aoSWkMjxuz3hYr7C@tassilo> (raw)
In-Reply-To: <CAP-5=fW112qVVdZGNpdRH0n-B2at4ENDjjNv4Hdehn5bEB9BSA@mail.gmail.com>

> Thanks Andi, I agree with the frustration. For an event like
> instructions I would like things merged. Does merging make sense for
> cycles given the different clock frequencies of p-cores and e-cores?

Frequencies are always per core anyways, even on non hybrid systems.

> Should the e-core cycles be scaled for this reason as there are fewer
> cycles within a second compared to a p-core?

No.

> 
> Perhaps we need a new json field to describe the hybrid merge-ability
> of events, say enabled on events like instructions or cache misses.
> Note the legacy events now have JSON descriptions:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/pmu-events/arch/common/common/legacy-hardware.json?h=perf-tools-next

Makes sense. At least for architectural events it's easy.
But I'll also defer it for now.


> 
> It would be nice if this were a generic feature and not just for perf top.

Makes sense, but I would also defer that to a future version.
The utility code is already partly factored out for reuse.


-Andi

      reply	other threads:[~2026-08-18 17:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 13:25 [PATCH v1] perf top: Merge hybrid common events Andi Kleen
2026-08-13 13:57 ` sashiko-bot
2026-08-17 19:40 ` Ian Rogers
2026-08-18 17:29   ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoSWkMjxuz3hYr7C@tassilo \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=ak@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.