From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Alexandr Moshkov <dtalexundeer@yandex-team.ru>,
"Michael S . Tsirkin" <mst@redhat.com>,
Seungjung Kim <seungjung0711@gmail.com>,
Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Subject: Re: [PATCH v2 2/8] migration: Introduce VMStateStructMember
Date: Tue, 18 Aug 2026 15:12:55 -0400 [thread overview]
Message-ID: <aoSut_FMo_ShRH9t@x1.local> (raw)
In-Reply-To: <20260818182441.404790-3-farosas@suse.de>
On Tue, Aug 18, 2026 at 03:24:35PM -0300, Fabiano Rosas wrote:
> /*
> - * @size or @size_offset specifies the size of the element embeded in
> - * the field. Only one of them should be present never both. When
> - * @size_offset is used together with VMS_VBUFFER, it means the size is
> - * dynamic calculated instead of a constant.
> + * @size directly specifies the size of the element being
> + * migrated.
> *
> - * When the field is an array of any type, this stores the size of one
> - * element of the array.
> + * @size_indirect specifies the offset inside a struct where the
> + * size of the element is stored.
> *
> - * NOTE: even if VMS_POINTER or VMS_ARRAY_OF_POINTER may be specified,
> - * this parameter always reflects the real size of the objects that a
> - * pointer point to.
> + * Only one of the above should be present (except for
> + * VMSTATE_MULTIPLY which uses .size as a multiplier). When
VMS_MULTIPLY
> + * @size_indirect is used together with VMS_VBUFFER, it means
> + * the size is dynamic calculated instead of a constant.
> + *
> + * When the field is an array of any type, these refer to the size
> + * of one element of the array.
> + *
> + * NOTE: even if VMS_POINTER or VMS_ARRAY_OF_POINTER may be
> + * specified, these parameters always reflect the real size of the
> + * objects that a pointer point to.
> + *
> + * @num_indirect specifies the offset inside a struct where the
> + * number of elements of an array is stored.
> */
--
Peter Xu
next prev parent reply other threads:[~2026-08-18 19:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 18:24 [PATCH v2 0/8] migration: Remove extra type-checking from vmstate macros Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 1/8] migration: Remove unused " Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 2/8] migration: Introduce VMStateStructMember Fabiano Rosas
2026-08-18 19:12 ` Peter Xu [this message]
2026-08-18 18:24 ` [PATCH v2 3/8] migration: Remove redundant flags Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 4/8] migration: Remove duplicate vmstate macros Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 5/8] migration: Add VMS_NO_STATE flag Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 6/8] migration: Check more vmstate flags Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 7/8] migration: Harden vmstate_handle_alloc Fabiano Rosas
2026-08-18 18:24 ` [PATCH v2 8/8] migration: Harden vmstate_size Fabiano Rosas
2026-08-18 19:12 ` [PATCH v2 0/8] migration: Remove extra type-checking from vmstate macros Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoSut_FMo_ShRH9t@x1.local \
--to=peterx@redhat.com \
--cc=dtalexundeer@yandex-team.ru \
--cc=farosas@suse.de \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seungjung0711@gmail.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.