From: Michal Hocko <mhocko@suse.com>
To: Joshua Hahn <joshua.hahnjy@gmail.com>
Cc: Shakeel Butt <shakeel.butt@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Jakub Kicinski <kuba@kernel.org>,
Meta kernel team <kernel-team@meta.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
Joy Chaoyue Xiong <joyxiong@yahoo.com>
Subject: Re: [PATCH] memcg: trim the per-cpu charge stock instead of draining it
Date: Wed, 19 Aug 2026 09:02:20 +0200 [thread overview]
Message-ID: <aoVU_OV777Xgascf@tiehlicka> (raw)
In-Reply-To: <20260819041747.1111965-1-joshua.hahnjy@gmail.com>
On Tue 18-08-26 21:17:46, Joshua Hahn wrote:
> On Tue, 18 Aug 2026 12:03:07 +0200 Michal Hocko <mhocko@suse.com> wrote:
> > The idea is sound. I would just not increase the overall stock size in
> > the same patch. Fine tuning can be done independently and ideally with
> > some numbers.
> > Would it make sense to start with MEMCG_STOCK_HIGH := MEMCG_CHARGE_BATCH
> > and MEMCG_CHARGE_BATCH := MEMCG_CHARGE_BATCH / 2. That would preserve
> > the maximum stock size while preventing all or nothing behavior which is
> > indeed suboptimal and pushing charging path to a slower path way too
> > aggressively.
>
> I like this idea and I think you meant { MEMCG_CHARGE_LOW :=
> MEMCG_CHARGE_BATCH / 2 } right?
Correct. Wrong auto-completion on my end.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2026-08-19 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 23:46 [PATCH] memcg: trim the per-cpu charge stock instead of draining it Shakeel Butt
2026-08-18 10:03 ` Michal Hocko
2026-08-18 15:08 ` Shakeel Butt
2026-08-19 4:17 ` Joshua Hahn
2026-08-19 7:02 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoVU_OV777Xgascf@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=joyxiong@yahoo.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.