From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
Eric Auger <eauger@redhat.com>
Subject: Re: [PATCH] block: save page offset gaps in cloned bio
Date: Wed, 19 Aug 2026 08:04:43 -0600 [thread overview]
Message-ID: <aoW3-6U0XkrHudpy@kbusch-mbp> (raw)
In-Reply-To: <20260819052306.GA32364@lst.de>
On Wed, Aug 19, 2026 at 07:23:06AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 17, 2026 at 09:59:08AM -0700, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > The cloned bio needs to inherit the accumulated gaps between vectors so
> > that we can know if this bio can subscribe to the iova coalescing
> > optimization.
>
> Makes sense.
>
> > The split remainder meanwhile can reset its gaps to 0
> > since it advanced beyond it and will start accounting from there.
>
> I don't really understand this part, though. As in I don't even
> understand what you mean here..
The accounting for the vector gaps happens at the same time we consider
a bio for splitting. When we do split, the gap value applies only to the
front bio because that's as far as been processed. The remaining split
bio should reset its gap value to 0, and it will be recalculated when it
continues through the split consideration.
next prev parent reply other threads:[~2026-08-19 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 16:59 [PATCH] block: save page offset gaps in cloned bio Keith Busch
2026-08-18 15:09 ` Eric Auger
2026-08-19 5:23 ` Christoph Hellwig
2026-08-19 14:04 ` Keith Busch [this message]
2026-08-19 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoW3-6U0XkrHudpy@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=eauger@redhat.com \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.