From: Stefan Eichenberger <eichest@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: francesco.dolcini@toradex.com, sbabic@nabladev.com,
uboot-imx@nxp.com, trini@konsulko.com,
franz.schnyder@toradex.com, stefan.eichenberger@toradex.com,
emanuele.ghidoli@toradex.com, sjg@chromium.org,
u-boot@lists.u-boot-project.org
Subject: Re: [PATCH v1] toradex: {aquila, smarc, verdin}-imx95: add board_fix_fdt
Date: Thu, 27 Aug 2026 10:38:30 +0200 [thread overview]
Message-ID: <ao_3hjKdBccr434g@eichest-laptop> (raw)
In-Reply-To: <CAOMZO5Df=ZoziqoYrAB-3rS+P-giWHjYrhKNBeQE6UKi2a+pBA@mail.gmail.com>
Hi Fabio,
On Wed, Aug 26, 2026 at 11:33:56AM -0300, Fabio Estevam wrote:
> Hi Stefan,
>
> On Tue, Aug 25, 2026 at 4:45 AM Stefan Eichenberger <eichest@gmail.com> wrote:
>
> > We discussed this internally and decided to implement it in the same way
> > as NXP does in board/nxp/imx95_frdm/imx95_frdm.c, but I'm not sure why
> > it was necessary to put it in the board file. Perhaps because it can
> > only be done in board_fix_fdt, which might be overwritten in the board
> > file anyway? If we were to do this for the entire architecture, we would
> > need to define a weak board_fix_fdt, which could be overwritten, if I
> > understand correctly.
>
> It seems we should handle this similarly to
> arch/arm/mach-imx/imx8m/soc.c, where peripherals are disabled
> according to the SoC fuses.
>
> Since this is a property of the SoC rather than a particular board, I
> would prefer to implement the fuse-based fixup once in the common
> i.MX95 SoC code instead of adding the same board_fix_fdt()
> implementation to every i.MX95 board.
>
> This would also avoid requiring each new i.MX95 board to duplicate
> this code in the future.
>
> Could you please move this to the common i. MX95 SoC code? If there is
> a technical reason we can't do that, we can revisit the per-board
> approach.
I think the only way I can implement it is by using board_fix_fdt. For
the iMX8M, the Linux device tree peripherals are disabled based on the
fuses. This has already been implemented for the iMX95
(ft_system_setup). However, board_fix_fdt disables the peripherals in
the device tree for U-Boot proper. I can't find a machine-specific
function. Am I missing something?
Should board_fix_fdt be defined in an arch based file? Wouldn't that be
incorrect, given that it is called 'board_...'?
Regards,
Stefan
prev parent reply other threads:[~2026-08-27 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-21 7:09 [PATCH v1] toradex: {aquila, smarc, verdin}-imx95: add board_fix_fdt Stefan Eichenberger
2026-08-25 1:24 ` Fabio Estevam
2026-08-25 7:45 ` Stefan Eichenberger
2026-08-26 14:33 ` Fabio Estevam
2026-08-27 8:38 ` Stefan Eichenberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao_3hjKdBccr434g@eichest-laptop \
--to=eichest@gmail.com \
--cc=emanuele.ghidoli@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=franz.schnyder@toradex.com \
--cc=sbabic@nabladev.com \
--cc=sjg@chromium.org \
--cc=stefan.eichenberger@toradex.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.