Re: [PATCH] hw/display/virtio-gpu: introduce virtio_gpu_simple_resource_new()

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Aug 27, 2026 at 11:09:41AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> All allocation sites used g_new0() which zero-initializes fields.
> However share_handle must be SHAREABLE_NONE (-1 on Unix, NULL on
> Windows) and dmabuf_fd must be -1, not 0. Centralize allocation and
> field initialization in a single constructor to fix this and reduce
> code duplication.
> 
> This fixes -display dbus with virtio-gpu blob resources. The other
> end is currently receiving qemu fd 0.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/display/virtio-gpu-rutabaga.c | 20 +++++-------------
>  hw/display/virtio-gpu.c          | 35 +++++++++++++++++++++-----------
>  include/hw/virtio/virtio-gpu.h   |  4 ++++
>  3 files changed, 32 insertions(+), 27 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|