All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Yifan Zhao <stopire@gmail.com>
Cc: Gao Xiang <xiang@kernel.org>, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device
Date: Thu, 27 Aug 2026 15:59:08 +0800	[thread overview]
Message-ID: <ao_uTDm54Pb16rIP@192.168.5.19> (raw)
In-Reply-To: <77994974-775a-4b5c-a872-4973ed40364e@gmail.com>

Hi Yifan,

On Thu, Aug 27, 2026 at 09:30:38AM +0800, Yifan Zhao wrote:
> 
> On 26/8/26 21:43, Gao Xiang wrote:
> > Source kernel commit: 7b00af2c5414dc01e0718deef7ead81102867636
> > 
> > Signed-off-by: Gao Xiang <xiang@kernel.org>
> > ---

...

> > diff --git a/lib/vmdk.c b/lib/vmdk.c
> > index 316a8ff..28381c8 100644
> > --- a/lib/vmdk.c
> > +++ b/lib/vmdk.c
> > @@ -51,8 +51,8 @@ int erofs_dump_vmdk_desc(FILE *f, struct erofs_sb_info *sbi)
> >   	int ret, i;
> >   	fprintf(f, desc_template_1, cid, parent_cid, subformat);
> > -	sectors = sbi->primarydevice_blocks << (sbi->blkszbits - 9);
> > -	ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->devname, 0);
> > +	sectors = sbi->dif0.blocks << (sbi->blkszbits - 9);
> > +	ret = erofs_vmdk_desc_add_extent(f, sectors, (char *)sbi->dif0.blocks, 0);
> 
> mistake? should use `src_path` instead of `blocks`

It's already got fixed.

Thanks,
Gao Xiang

> 
> 
> Thanks,
> 
> Yifan Zhao


  reply	other threads:[~2026-08-27  7:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-26 13:43 [PATCH 1/4] erofs-utils: lib: fix wrong forward declaration of `erofs_metamgr` Gao Xiang
2026-08-26 13:43 ` [PATCH 2/4] erofs-utils: lib: use `struct erofs_device_info` for the primary device Gao Xiang
2026-08-27  1:30   ` Yifan Zhao
2026-08-27  7:59     ` Gao Xiang [this message]
2026-08-26 13:43 ` [PATCH 3/4] erofs-utils: lib: refactor unencoded chunk handling Gao Xiang
2026-08-26 13:43 ` [PATCH 4/4] erofs-utils: get rid of hashmap Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao_uTDm54Pb16rIP@192.168.5.19 \
    --to=xiang@kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=stopire@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.