From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Andy Shevchenko <andy@kernel.org>, Kees Cook <kees@kernel.org>,
Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulfh@kernel.org>,
Edward Cree <ecree.xilinx@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] ice: use string choice helpers
Date: Thu, 20 Aug 2026 09:43:05 +0300 [thread overview]
Message-ID: <aoah-R24B2u_3kpS@ashevche-desk.local> (raw)
In-Reply-To: <20260820061113.4176623-4-dmantipov@yandex.ru>
On Thu, Aug 20, 2026 at 09:11:11AM +0300, Dmitry Antipov wrote:
> Prefer 'str_locked_unlocked()', 'str_on_off()' and 'str_true_false()'
> string choice helpers over hardcoded strings where appropriate.
...
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -35,6 +35,7 @@
> #include <linux/linkmode.h>
> #include <linux/bpf.h>
> #include <linux/btf.h>
> +#include <linux/string_choices.h>
> #include <linux/auxiliary_bus.h>
> #include <linux/avf/virtchnl.h>
> #include <linux/cpu_rmap.h>
This is a mess. I think they have to think (start thinking) about IWYU
principle. So, please add this include to the each file you touch with
this patch. Left the rest to the ICE developers to amend.
With that being done,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-20 6:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 6:11 [PATCH 1/6] lib/string_choices: add few more convenient choice helpers Dmitry Antipov
2026-08-20 6:11 ` [PATCH 2/6] coccinelle: add rules to match recently introduced " Dmitry Antipov
2026-08-20 6:11 ` [PATCH 3/6] ASoC: cs48l32: use str_lock_unlock() helper Dmitry Antipov
2026-08-20 6:39 ` Andy Shevchenko
2026-08-20 6:11 ` [PATCH 4/6] ice: use string choice helpers Dmitry Antipov
2026-08-20 6:43 ` Andy Shevchenko [this message]
2026-08-20 9:30 ` Przemek Kitszel
2026-08-20 6:11 ` [PATCH 5/6] mmc: sdhci-of-k1: use str_fail_pass() helper Dmitry Antipov
2026-08-20 6:44 ` Andy Shevchenko
2026-08-20 6:11 ` [PATCH 6/6] net: sfc: use string choice helpers Dmitry Antipov
2026-08-20 6:47 ` Andy Shevchenko
2026-08-20 6:39 ` [PATCH 1/6] lib/string_choices: add few more convenient " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoah-R24B2u_3kpS@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Julia.Lawall@inria.fr \
--cc=adrian.hunter@intel.com \
--cc=andy@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=david.rhodes@cirrus.com \
--cc=dmantipov@yandex.ru \
--cc=ecree.xilinx@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=przemyslaw.kitszel@intel.com \
--cc=rf@opensource.cirrus.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.