From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CB692C15A0 for ; Thu, 20 Aug 2026 07:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787211095; cv=none; b=XDdDPdph+athvsnuXUg8r9vmDP5eyOftihd2znjpV326uIqZrZM+8zU1BLuAth3xZzTXxo8LpwbRq1QPfCXJdTLE2LiCqXAgEq2c6YPn5Di9W32gVQezwEoS9mz4zKkrgICVSPQ4Vhu4fSKGbdhoU1FMQlnar0t7pYFmzuNfB40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787211095; c=relaxed/simple; bh=n6+gCytDTg6+ZwJPiuj1OKZtZtW28bJaa+F1Bn12XD8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Jft3t3sssbCNOudGPpkYz2XB6psHcRQ6dllyv2PUiWyNChoyJciMzT0vpfI5jSF+a07y5asKkURFfa3y22CAyiE5bLJZDvr/E1bXKQE5FXLlDPWcdn0qCZyCw3YW0H+SHRaIn3aXr8kqTTmVVD3HeOOWa9LHOYNMoq855U2cK/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=dV3iNCwq; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="dV3iNCwq" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so20225555e9.2 for ; Thu, 20 Aug 2026 00:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1787211091; x=1787815891; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Vkh64L6UzTSA8Xf512Ftg+zC5GW4fV+5Ea4/Falg5FQ=; b=dV3iNCwqPQk0XBiwsqr8UHrA3AXNAJgyKaOhqztDpPCXodY3hK6RARyuBikA+CVpfS wx5HakaRUSbNfO+Jz5U30gzvmO1NawSLTx94kvWPLIidXFRD0D1ZXT3wmHQeUX8q6K0A mX6lm3JrC506e1TYbFs1iuzRcaQW5buqnvL5NQUR1CznYBlVg3YwycoB8s1FYyzP2V4U SaF7VQ4kf/H3DPJnaMZtpQTRGuq1Q/a+TbVA7p8OkA40wxrh8Rgac22w2S0AmL2ncdEc dkFOJULdPe60ul93twcvTOQAHF5Gi+3SDlBb4NzF3h2XacxjIQahvsjdR0kHEQesX7gp Rq7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787211091; x=1787815891; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Vkh64L6UzTSA8Xf512Ftg+zC5GW4fV+5Ea4/Falg5FQ=; b=A6v8H79Hb7sWKLZ/nfKeVQZ1kfICgJvGTpNiYgPWsfdXEReZRqnzXjnEo86wEymr4+ E1qOobL89J+ZjMs84BrSdWsFimnm1hYP+2S7goyV4Sghrzmzb133UzFCTImMVIK7Mi7A ODwhiHp51gINuN3Z/rDSprZyMyntsT8QflCwVGYpQifXDCBsY7EYrBWminAFKenqkRMg Pis0yVxXsQqT3OMf378pNwc5Q3ibKNw6Hm178julNZ3SHLPRurQ7X+Dn7ngPIAVT/fsw 9cwktcY0y2kNAQPaYPNpJuwj/iUWP4Mqo8vNBCUqTRer4rW1P+FKBq2SwwaAW7IQ78zi 1LpQ== X-Forwarded-Encrypted: i=1; AHgh+Ro6+oYUfzgA9xjRBCjCOUBC/4qWEowXv21aSEt4GUmxpP6mp0p2vHkX5cNmuUuHrG2tjlk4JYEsmpkAU4w=@vger.kernel.org X-Gm-Message-State: AOJu0Yx37QqomeG6arsXAabAjG/dLSVZEyrpV7PEpq9Hzhqn1fg7DYsh K4KQj8QjxMqeVJ8B2gH67i3cqWUePOGOgz6ujKyYxhdWkYx0bimpZ3E0BUFC2o/SCP8= X-Gm-Gg: AR+sD12uliG1ncF4ro0FnPzGeS8jjpZgKHlBx0cvxl74QnN5BROOde/bw5eRIyG38vt t5fppPU/DUL5qWcn9EQHZKIFV0XTHHPEgqC8rFOr7w+N2LX82eGmcUy7E7o7neT/axC2+gr5+F2 Cipy6c1KrSYQr1juCHnxpTvuDXVku39e5EsWbIBwl2p+QOPxYkviZ5RS+dNiSALu2pzq32in6bk Os5BX6G1apzkok+NiSE2cCtcw6K0XeBCaU0W97LNiDri53DQZYDBnZwKut+5rSxg6x8MhRPZ/ZK pZgwyKLITaSfO7ZWmhiVfGSLkvWa78J4eex361M+bW5dVuqmWgxuDaeld7ouexM5ZaZ0vm+ky/H rUPVx3vXY1/fZT+3Roc9F6iZcFRA+G6IS6oBabS0d3YYF7YESj3tWOU93fl/9OpLicnKI1W4R9l TC0rg9ECvbs1py2j363cdLbVbiEnPX3Ct3JPJIIZtJR0CnqLDSKFoIqFsV5UQcIXW2mdl96fxy5 kvf X-Received: by 2002:a05:600c:628d:b0:499:8ae1:b900 with SMTP id 5b1f17b1804b1-499aa1c9610mr197073495e9.12.1787211091250; Thu, 20 Aug 2026 00:31:31 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-499ab2a8b34sm147237995e9.8.2026.08.20.00.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Aug 2026 00:31:30 -0700 (PDT) Date: Thu, 20 Aug 2026 09:31:29 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: lijun Cc: andy@kernel.org, geert@linux-m68k.org, fourier.thomas@gmail.com, bhelgaas@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management Message-ID: References: <20260820013826.1927061-1-lijun01@kylinos.cn> <8f38b185-a0df-46ad-98cb-b5acda1823b6@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ira5yzlcddjnr6ak" Content-Disposition: inline In-Reply-To: <8f38b185-a0df-46ad-98cb-b5acda1823b6@kylinos.cn> --ira5yzlcddjnr6ak Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management MIME-Version: 1.0 On Thu, Aug 20, 2026 at 02:04:46PM +0800, lijun wrote: > Thank you! This suggestion is very useful to me. > -------- > I think the same is needed for your firmware/arm_scmi patch and also for > the bluetooth one. >=20 > The usage of DEFINE_SIMPLE_DEV_PM_OPS() is an improvement, but now you > have (at least) three series in flight and the trivial feedback you > received here applies to all three. As someone who also sends many > patches, I recommend to get up to speed slowly. Work on a single patch > first, and only once you get that in---or at least positive feedback on > it---address one or two further drivers. When you have a handful of > patches in, you can speed up. But as it is now, you only occupy many > people finding the same issues in your patches. Please also fix your mail user agent to use proper quoting. (For Thunderbird maybe: "Account Settings" -> "Composition & Adressing" -> [x] "Automatically quote the original message when replying" + "When quoting start my reply below the quote".) Thanks Uwe --ira5yzlcddjnr6ak Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmqGrU4ACgkQj4D7WH0S /k73RQf/XEPT7KSraQ5wZpKENtOXisXzT66pRVwrkea/d/EAMLAr6MPA64/nUWrs NOCrh41eX39BSXHg7OWDG9shIc5OUSN37T7VFO4coYlIRG+gjWypOmrz86tNQNk/ E/qMXO0wGVrnfFOroifrQy81+74Y5MF/75pL/rKRaqJ6JXi3Ej0JKrAowzFw2AA7 JUYy624ZKC3B7Z7ddAwrh2N4ENA42AoE9ZoN/NGfAH/98bEWLWCP5qamIvfrpc5W srXTViecwc+rGBFXOlhMXvDTM61TsEhg81pITDKAIUpby/eEEfMiAE/YvesAHOHR OAahvMDVkwKPj53xi7nPakI0lksaog== =1b7Y -----END PGP SIGNATURE----- --ira5yzlcddjnr6ak--