All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Yanfei Xu <isyanfei.xu@gmail.com>
Cc: Yanfei Xu <yanfei.xu@bytedance.com>,
	qemu-devel@nongnu.org, farosas@suse.de, lizhijian@fujitsu.com,
	Jinpu Wang <jinpu.wang@cloud.ionos.com>
Subject: Re: [PATCH 2/3] migration/rdma: Post initial receive before accepting
Date: Thu, 20 Aug 2026 09:37:30 -0400	[thread overview]
Message-ID: <aocDGlrrUSluJWHF@x1.local> (raw)
In-Reply-To: <1313593f-9468-4779-b74e-addcdd012e8b@gmail.com>

On Thu, Aug 20, 2026 at 02:22:26PM +0800, Yanfei Xu wrote:
> 
> On 2026/8/20 03:16, Peter Xu wrote:
> > On Mon, Aug 17, 2026 at 06:51:16PM +0800, Yanfei Xu wrote:
> > > The source return-path thread can send READY before the destination has
> > > posted its initial receive.  Since RNR retries default to zero, the send
> > > can fail and abort migration.
> > > 
> > > Post the initial receive before rdma_accept() to close this window.
> > > 
> > > Fixes: 55cc1b5937a8 ("migration: create a dedicated connection for rdma return path")
> > > Signed-off-by: Yanfei Xu<yanfei.xu@bytedance.com>
> > This one looks correct to me,
> > 
> > Reviewed-by: Peter Xu<peterx@redhat.com>
> > 
> > Do you have way to reproduce it, or is this theory (or can be reproduced by
> > adding delays)?
> 
> Yes, adding delays can reproduce it.
> 
> For example with sleep(1) and related traces, log at source side:

Thanks for the info, then let's add some of such info into the commit log,
to be clear on how it would trigger (and how likely).

-- 
Peter Xu



  reply	other threads:[~2026-08-20 13:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-17 10:51 [PATCH 0/3] migration/rdma: Misc RDMA migration fixes Yanfei Xu
2026-08-17 10:51 ` [PATCH 1/3] migration/rdma: Fix write-side shutdown Yanfei Xu
2026-08-19 14:58   ` Fabiano Rosas
2026-08-19 19:19   ` Peter Xu
2026-08-17 10:51 ` [PATCH 2/3] migration/rdma: Post initial receive before accepting Yanfei Xu
2026-08-19 19:16   ` Peter Xu
2026-08-20  5:46     ` Jinpu Wang
2026-08-20  6:22     ` Yanfei Xu
2026-08-20 13:37       ` Peter Xu [this message]
2026-08-17 10:51 ` [PATCH 3/3] migration/rdma: Retry control sends on full queue Yanfei Xu
2026-08-19 19:18   ` Peter Xu
2026-08-20 10:27     ` Yanfei Xu
2026-08-20 13:47       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aocDGlrrUSluJWHF@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=isyanfei.xu@gmail.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=lizhijian@fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yanfei.xu@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.