From: Kevin Wolf <kwolf@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Gonglei (Arei)" <arei.gonglei@huawei.com>,
"zhenwei pi" <zhenwei.pi@linux.dev>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Hanna Reitz" <hreitz@redhat.com>,
qemu-block@nongnu.org, devel@lists.libvirt.org
Subject: Re: [PATCH 5/6] hw/block: validate the fdc sector position fits within bounds
Date: Thu, 20 Aug 2026 17:47:43 +0200 [thread overview]
Message-ID: <aochnwGTcIXwRDQu@redhat.com> (raw)
In-Reply-To: <20260819-fixes-for-11-2-v1-5-b7981c2cc371@linaro.org>
Am 19.08.2026 um 11:22 hat Alex Bennée geschrieben:
> Previously the guest controlled the value of last_sec and wasn't
> particularly careful to check it didn't exceed the media size. We
> can't re-use drv->last_sec as that changes as we do operations so we
> set media_last_sect when the geometry is probed.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3800
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
If it's not too hard, I would appreciate a qtest case that reproduces
the problem in the pre-patch state and shows that the behaviour
afterwards is right, including after media change to a floppy of a
different size.
Kevin
next prev parent reply other threads:[~2026-08-20 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 9:22 [PATCH 0/6] various fixes for 11.2 (gitlab, tests, char-fe, fdc, deprecations) Alex Bennée
2026-08-19 9:22 ` [PATCH 1/6] gitlab: use .base_meson_job_template for macOS jobs Alex Bennée
2026-08-19 9:22 ` [PATCH 2/6] tests/arm: add explicit CFLAGS for system build Alex Bennée
2026-08-19 9:22 ` [PATCH 3/6] gitlab: add arm-softmmu tests to the macOS build Alex Bennée
2026-08-19 9:22 ` [PATCH 4/6] char-fe: implement qemu_chr_fe_backend_name Alex Bennée
2026-08-19 9:22 ` [PATCH 5/6] hw/block: validate the fdc sector position fits within bounds Alex Bennée
2026-08-20 15:47 ` Kevin Wolf [this message]
2026-08-19 9:22 ` [PATCH 6/6] docs: deprecate virtio-crypto Alex Bennée
2026-08-19 9:32 ` Mohamed Mediouni
2026-08-19 21:56 ` Michael S. Tsirkin
2026-08-20 0:22 ` Mohamed Mediouni
2026-08-20 13:15 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aochnwGTcIXwRDQu@redhat.com \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=amit@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=devel@lists.libvirt.org \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=zhenwei.pi@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.