From: Dan Carpenter <error27@gmail.com>
To: "myeonghyeon.park" <myeonghyeon.park@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: reorder conditions to avoid else branch
Date: Thu, 20 Aug 2026 21:53:42 +0300 [thread overview]
Message-ID: <aodNNvjuCO8lpQrk@stanley.mountain> (raw)
In-Reply-To: <20260820162601.74952-1-myeonghyeon.park@gmail.com>
On Fri, Aug 21, 2026 at 01:26:01AM +0900, myeonghyeon.park wrote:
> Fix the checkpatch.pl warning:
>
> "WARNING: else is not generally useful after a break or return"
>
> in core/rtw_recv.c.
>
> Return early when the SN_EQUAL() condition is met and break when
> SN_LESS() condition is false to eliminate the unnecessary else branch.
>
Just ignore checkpatch when it is wrong.
regards,
dan carpenter
prev parent reply other threads:[~2026-08-20 18:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 16:26 [PATCH] staging: rtl8723bs: reorder conditions to avoid else branch myeonghyeon.park
2026-08-20 17:10 ` Greg Kroah-Hartman
2026-08-20 18:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aodNNvjuCO8lpQrk@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=myeonghyeon.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.