All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>,
	fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 3/5] generic/746: skip on zoned btrfs
Date: Thu, 20 Aug 2026 22:38:23 -0700	[thread overview]
Message-ID: <aofkT7rrfQYCr6yK@infradead.org> (raw)
In-Reply-To: <20260819131606.1478488-4-johannes.thumshirn@wdc.com>

On Wed, Aug 19, 2026 at 03:16:03PM +0200, Johannes Thumshirn wrote:
> The test relies on loop device discards punching holes in the backing
> image file (holes are then detected via fiemap on the backing file).
> Zoned btrfs does not support fallocate/punch hole, so fstrim on the
> loop device cannot free space in the backing file and the test cannot
> work.
> 
> Skip the test on filesystems that do not support "fpunch"

Shouldn't _require_fstrim return false for zoned btrfs given that
trimming makes zero sense?  Otherwise once zoned btrfs at some point
supports fpunch (which it really should), this starts breaking again.


  reply	other threads:[~2026-08-21  5:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 13:16 [PATCH v2 0/5] fstests: misc fixes for zoned btrfs Johannes Thumshirn
2026-08-19 13:16 ` [PATCH v2 1/5] common/btrfs: fix awk field separator in _check_temp_fsid Johannes Thumshirn
2026-08-21  5:36   ` Christoph Hellwig
2026-08-19 13:16 ` [PATCH v2 2/5] btrfs/199: skip on zoned devices Johannes Thumshirn
2026-08-21  5:37   ` Christoph Hellwig
2026-08-19 13:16 ` [PATCH v2 3/5] generic/746: skip on zoned btrfs Johannes Thumshirn
2026-08-21  5:38   ` Christoph Hellwig [this message]
2026-08-19 13:16 ` [PATCH v2 4/5] btrfs/284: skip on zoned devices Johannes Thumshirn
2026-08-21  5:39   ` Christoph Hellwig
2026-08-19 13:16 ` [PATCH v2 5/5] generic/781: fix copyright Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aofkT7rrfQYCr6yK@infradead.org \
    --to=hch@infradead.org \
    --cc=fstests@vger.kernel.org \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.