Re: [PATCH v2 0/2] ivepatch: Fix several bugs found during replace set implementation

[Petr Mladek <pmladek@suse.com>]

On Thu 2026-08-20 08:40:40, Josh Poimboeuf wrote:
> On Wed, Aug 19, 2026 at 12:24:31PM +0200, Petr Mladek wrote:
> > On Sun 2026-08-16 17:04:40, Yafang Shao wrote:
> > > These fixes were found while implementing the replace set series [0].
> > > They are independent of that series and can be applied separately.
> > > 
> > > Link: https://lore.kernel.org/live-patching/20260809091954.22930-1-laoar.shao@gmail.com [0]
> > > 
> > > Changes:
> > > v1->v2:
> > > - minor improvements and acked-by (Song)
> > > - fix issues reported by sashiko
> > > 
> > > v1: https://lore.kernel.org/live-patching/20260813030408.9761-1-laoar.shao@gmail.com/
> > > 
> > > Yafang Shao (2):
> > >   livepatch: Fix wrong index in funcs cleanup error path
> > 
> > This patch is against scripts/livepatch/init.c which is part of
> > klp-build framework. The klp-build-related changes usually
> > go via the "tip" tree by Josh.
> > 
> > >   livepatch: Fix UAF of unregistered patch kobjects
> > 
> > This patch is against the kernel/livepatch/* code. These changes
> > usually go via the "livepatching" tree by me.
> > 
> > Honestly, I am not sure how to handle this situation.
> > Josh?
> 
> The scripts/livepatch changes have tended to be tied to objtool, which
> is why they have gone through the tip tree.

Yup.

> I'm open to suggestions or ideas.  We could possibly rename or move that
> scripts/livepatch directory (scripts/klp-build/?  tools/objtool/klp-build/?)
> if that makes the boundary less confusing.

I like the idea with klp-build name. It might help people to
distinguish the two areas.

> Or might there be some other maintainership model or way of splitting up
> the files?

I guess that we need to keep the core livepatching code and klp-build
stuff separated because klp-build is very tight with objtool and
objtool is tight with arch code, ...

It might help to crate KLP BUILD section in MAINTAINERS.
It would point to the tip tree. You would be the maintainer.
And other livepatch people, including live-patching mailing list,
might stay as reviewers.

> In any case, I'll go ahead and queue up patch 1 for tip for now.

Thanks a lot.

Best Regards,
Petr