All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Iliopoulos <ailiop@suse.com>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: remove unused setup_profiling_timer function
Date: Fri, 21 Aug 2026 11:41:29 +0200	[thread overview]
Message-ID: <aogdSZi3gWqaSfnc@technoir> (raw)
In-Reply-To: <047975cb5fdeb0e3cb52cb78d55c3a45023cc992.camel@physik.fu-berlin.de>

On Thu, Aug 20, 2026 at 04:00:37PM +0200, John Paul Adrian Glaubitz wrote:
> Hi Anthony,
> 
> On Thu, 2026-08-20 at 14:39 +0200, Anthony Iliopoulos wrote:
> > setup_profiling_timer() is not used by any code at this point. Since a
> > default weak implementation exists, there is no need to keep this
> > arch-specific definition around. Remove it along with the now-redundant
> > profile header includes.
> 
> Do you have any clue why it was still implemented for LoongArch which is
> a rather new architecture? I'm also seeing that it's not used anywhere,
> I'm just wondering why it was not removed before and why it was even
> included when LoongArch was added.

Its addition to LoongArch [1] slightly predates converting it to a weak
function [2], so up until that point all archs had to include the stub.

Regards,
Anthony

[1] 46859ac8af52 ("LoongArch: Add multi-processor (SMP) support")
[2] 787dbea11a5d ("profile: setup_profiling_timer() is moslty not implemented")

  reply	other threads:[~2026-08-21  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20 12:39 [PATCH] sh: remove unused setup_profiling_timer function Anthony Iliopoulos
2026-08-20 14:00 ` John Paul Adrian Glaubitz
2026-08-21  9:41   ` Anthony Iliopoulos [this message]
2026-08-21 13:15   ` Geert Uytterhoeven
2026-08-21  7:36 ` Geert Uytterhoeven
2026-08-21  9:51   ` Anthony Iliopoulos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aogdSZi3gWqaSfnc@technoir \
    --to=ailiop@suse.com \
    --cc=dalias@libc.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.